Skip to content

fix(@angular-devkit/build-angular): update the ECMA output warning message to be more actionable #24698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angular-robot merged 1 commit into from
Feb 10, 2023
Merged

fix(@angular-devkit/build-angular): update the ECMA output warning message to be more actionable #24698

angular-robot merged 1 commit into from
Feb 10, 2023

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 10, 2023

Update the TypeScript compiler options "target" and "useDefineForClassFields" are set to "ES2022" warning message to be more actionable.

Closes: #24697

@alan-agius4
fix(@angular-devkit/build-angular): update the ECMA output warning me…
788d2c7 
…ssage to be more actionable

Update the `TypeScript compiler options "target" and "useDefineForClassFields" are set to "ES2022"` warning message to be more actionable.

Closes: angular#24697
@alan-agius4 alan-agius4 marked this pull request as ready for review February 10, 2023 16:48
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 10, 2023
@alan-agius4 alan-agius4 requested a review from clydin February 10, 2023 17:06
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 10, 2023
@ngbot
Copy link

ngbot bot commented Feb 10, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: e2e-cli-win" is failing
    pending status "mergeability" is pending
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-robot angular-robot bot merged commit c65b026 into angular:main Feb 10, 2023
@alan-agius4 alan-agius4 deleted the warning-ts-target-version branch February 10, 2023 20:46
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 13, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Browserslist is ignored.

2 participants

@alan-agius4 @clydin