-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(): add typings to the blueprints. #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,9 @@ | |
/libpeerconnection.log | ||
npm-debug.log | ||
testem.log | ||
/typings/ | ||
|
||
# e2e | ||
/e2e/*.js | ||
/e2e/*.map | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,25 +8,31 @@ | |
"playSound": false | ||
} | ||
}, | ||
"scripts": { | ||
"start": "ng server", | ||
"postinstall": "typings install --ambient" | ||
}, | ||
"private": true, | ||
"dependencies": { | ||
"angular2": "2.0.0-beta.0", | ||
"angular2": "2.0.0-beta.3", | ||
"es6-promise": "^3.0.2", | ||
"es6-shim": "^0.33.3", | ||
"reflect-metadata": "0.1.2", | ||
"rxjs": "5.0.0-beta.0", | ||
"systemjs": "0.19.4", | ||
"zone.js": "0.5.10" | ||
"zone.js": "0.5.11" | ||
}, | ||
"devDependencies": { | ||
"angular-cli": "0.0.*", | ||
"angular-cli-github-pages": "^0.2.0", | ||
"ember-cli-inject-live-reload": "^1.3.0", | ||
"glob": "^6.0.4", | ||
"jasmine-core": "^2.3.4", | ||
"karma": "^0.13.15", | ||
"karma-chrome-launcher": "^0.2.1", | ||
"karma-jasmine": "^0.3.6", | ||
"protractor": "^3.0.0", | ||
"typescript": "^1.7.3" | ||
"typescript": "^1.7.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe we should opt angular-cli users into the TS 1.8 beta. Then you get features like comments in the tsconfig.json which is really nice in a templated file - gives the user in-situ instructions for editing it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should make those kind of version upgrade a separate PR, but I agree. I can do a quick follow up today. |
||
"typings": "^0.6.6" | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../tsconfig.json |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"compilerOptions": { | ||
"declaration": false, | ||
"emitDecoratorMetadata": true, | ||
"experimentalDecorators": true, | ||
"mapRoot": "", | ||
"module": "system", | ||
"moduleResolution": "node", | ||
"noEmitOnError": true, | ||
"noImplicitAny": false, | ||
"outDir": "../dist/", | ||
"rootDir": ".", | ||
"sourceMap": true, | ||
"sourceRoot": "/", | ||
"target": "es5" | ||
}, | ||
"exclude": [ | ||
"e2e/", | ||
"node_modules/", | ||
"typings/main", | ||
"typings/main.d.ts" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"dependencies": {}, | ||
"devDependencies": { | ||
}, | ||
"ambientDevDependencies": { | ||
"jasmine": "github:DefinitelyTyped/DefinitelyTyped/jasmine/jasmine.d.ts#26c98c8a9530c44f8c801ccc3b2057e2101187ee" | ||
}, | ||
"ambientDependencies": { | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should test what happens when a typing is removed from typings.json - make sure that this will remove it from the typings dir. otherwise contributors end up with stale extra typings files in their working dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not remove the typings removed from typings.json.
I filed typings/typings#170 to do just that.