feat(): add typings to the blueprints.

[hansl]

Simply add typings to the blueprints, and use the browser ones in tsconfig.

This should get the upgrade to angular beta.2 unblocked.

[alexeagle]

this is not nice. Only atom understands this property, not tsc.

Your options are

• use exclude, meaning all .ts and .d.ts files in this directory and children
• use files =[] which means you need to specify the application entry point(s) as well as the typings/browser.d.ts file (or the typings/main.d.ts file if targetting node runtime)

[hansl]

Done, replaced with an exclude for the main file (we only need browsers AFAIK).

[alexeagle]

LGTM

[filipesilva]

Excluding the file means the typings we have will never be accessible.

This is the problem I ran into: typescript allows you to either list all files, or exclude some of them. To use exclude you'd need typings to be installed on the src/ folder, and exclude the ones you don't want.

Edit: as @alexeagle said, this needs to have the main typings file and the app entry point. There were duplicate definitions errors because in angular2 beta.0 the typings for jasmine are included. In beta.2 there are no duplicate errors.

  "files": [
    "../typings/browser.d.ts",
    "app.ts"
  ]

[filipesilva]

On the other hand, beta.2 breaks ng serve for the same reason, so... a bit of a catch-22 here. You can test this by just upgrading npm angular2 on the test project.

[hansl]

We cannot use files because every unittest is its own entry point.

[hansl]

I'm going to try to upgrade my local app to beta.2 and see what happens. BRB.

[hansl]

@alexeagle @filipesilva @IgorMinar

Adding these typings work, when we pass in rootFilePaths to the broccoli-typescript. It's a custom property that is used by the TypeScript language service, defined in the ServiceHost. Basically we append our list of TS files to that property. rootFilePaths isn't standard though, in the official TypeScript host it's named getScriptFileNames.

After looking deeply into this (and it also gazed back into me, Nietzsche-style), I see a few problems with our current scripts in angular-cli:

• nothing is typescript, but the source of the files is definitely TypeScript. We should replace our JS files by their TS sources and output the proper JS on prepublish. That's not much work I'll see if I can fit this into my schedule.
• moving the typings.json to src/ isn't as convenient as it looks. It removes the use of process.cwd() from the angular broccoli class, but you need to cd src everytime you use typings, which isn't great.

Finally, I added a move to beta.3 in here, but I will remove it before I submit. The reason is we need this change in our npm package before we upgrade to beta.3. So unless you guys tell me it's okay to have a few days (until next release) where apps generated from master do not work (because the npm package isn't published), then I'll undo the upgrade. @filipesilva will be happy to know this is super straightforward though; just change the scaffold dependency up to beta.3 and the zone to .11 and it's good to go as is.

If you want to use this PR as a local test; once the app is generated you need to replace the node_modules/ version of angular-cli with your local copy. Basically, do the following shell commands:

./angular-cli/bin/ng new foo
cp -rf ./angular-cli foo/node_modules/
cd foo/
ng build  # will work

Please note that the tsc will not work unless you add all the entry points to the tsconfig.json files key. The problem is each spec file is its own entry point, so this would become unmanageable.

With that, I'm taking a break. Please take a look at your convenience.

[filipesilva]

Whoa @hansl , great work! I can't follow up on this until next wednesday as I'm just leaving for a vacations, but there's enough info here for someone else to merge for now.

Again, thanks for looking into this, it was driving me nuts.

[filipesilva]

lgtm 👍

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}