fix(@schematics/angular): resolve windows paths in tsconfig migration #16807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added
the
target: patch
filipesilva
commented
Jan 31, 2020
| @@ -110,12 +110,12 @@ function updateTsConfig(tree: Tree, builderConfig: JsonAstObject, builderName: B | |||
|
|
|||
| const mainOption = findPropertyInAstObject(option, 'main'); | |||
| if (mainOption && mainOption.kind === 'string') { | |||
| newFiles.push(posix.relative(posix.dirname(tsConfigPath), mainOption.value)); | |||
| newFiles.push(relative(dirname(tsConfigPath), mainOption.value).replace(/\\/g, '/')); | |||
There was a problem hiding this comment.
Posix resolution on Windows will still prefer the windows path separator: https://nodejs.org/api/path.html#path_path_normalize_path
But here what we really want is a "TS-style" separator instead, which is forward slash everywhere.
There was a problem hiding this comment.
Also unfortunate is that this code:
const tsConfigPath = 'projects\\another-app\\tsconfig.app.json';
console.log(dirname(tsConfigPath));
console.log(posix.dirname(tsConfigPath));
Will print . twice on Linux, but on Windows will print projects\another-app and .. So I don't think the posix functions help us at all here.
filipesilva
force-pushed
the
v9-migration-tsconfig-posix
branch
2 times, most recently
from
b5c19da to
29561fd
Compare
filipesilva
force-pushed
the
v9-migration-tsconfig-posix
branch
from
29561fd to
74e16dd
Compare
alan-agius4
approved these changes
Jan 31, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16800