Skip to content

feature: disable --mobile #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2016
Merged

feature: disable --mobile #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ env:
matrix:
- SCRIPT=lint
- SCRIPT=test
- TARGET=mobile SCRIPT=mobile_test
# - TARGET=mobile SCRIPT=mobile_test
matrix:
exclude:
- node_js: "6"
env: SCRIPT=lint
- os: osx
node_js: "5"
env: SCRIPT=lint
- os: osx
env: TARGET=mobile SCRIPT=mobile_test
# - os: osx
# env: TARGET=mobile SCRIPT=mobile_test

before_install:
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update; fi
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ You can modify the these scripts in `package.json` to run whatever tool you pref

### Support for offline applications

Angular-CLI includes support for offline applications via the `--mobile` flag on `ng new`. Support is experimental, please see the angular/mobile-toolkit project and https://mobile.angular.io/ for documentation on how to make use of this functionality.
**The `--mobile` flag has been disabled temporarily. Sorry for the inconvenience.**

~~Angular-CLI includes support for offline applications via the `--` flag on `ng new`. Support is experimental, please see the angular/mobile-toolkit project and https://mobile.angular.io/ for documentation on how to make use of this functionality.~~

### Commands autocompletion

Expand Down
7 changes: 7 additions & 0 deletions addon/ng2/commands/new.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ const NewCommand = Command.extend({
new SilentError(`We currently do not support a name of "${packageName}".`));
}

if (commandOptions.mobile) {
return Promise.reject(new SilentError(
'The --mobile flag has been disabled temporarily while we await an update of ' +
'angular-universal for supporting NgModule. Sorry for the inconvenience.'
));
}

commandOptions.blueprint = normalizeBlueprint(commandOptions.blueprint);

if (!commandOptions.directory) {
Expand Down