Skip to content

style: enable tslint rules that were removed due to prettier #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2019
Merged

style: enable tslint rules that were removed due to prettier #15138

merged 2 commits into from
Jul 25, 2019

Conversation

alan-agius4
Copy link
Collaborator

Prettier was disabled in this PR #14940

Until we re-introduce it again, we should re-introduce certain lint rules to maintaince a coding standards.

Also, this increases the max-line-length to 140 instead of 100.

@alan-agius4 alan-agius4 requested a review from clydin July 21, 2019 17:08
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jul 21, 2019
@alan-agius4 alan-agius4 removed the request for review from clydin July 21, 2019 17:13
Prettier was disabled in this PR #14940

Until we re-introduce it again, we should re-introduce certain lint rules to maintaince a coding standards.

Also, this increases the `max-line-length` to `140` instead of `100`.
@alan-agius4 alan-agius4 requested a review from clydin July 21, 2019 17:37
@vikerman vikerman merged commit 15ef15e into angular:master Jul 25, 2019
@alan-agius4 alan-agius4 deleted the lint-rules branch July 25, 2019 04:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants