style: remove redundant max-line-length disables and fix other lint issues

Author: alan-agius4

packages/angular/cli/lib/cli/index.ts

@@ -72,7 +72,7 @@ export default async function(options: { testing?: boolean; cliArgs: string[] })
 
         logger.fatal(
           `An unhandled exception occurred: ${err.message}\n` +
-            `See "${logPath}" for further details.`
+            `See "${logPath}" for further details.`,
         );
       } catch (e) {
         logger.fatal(

packages/angular/cli/utilities/config.ts

@@ -86,8 +86,8 @@ export function getWorkspace(
   if (error) {
     throw new Error(
       `Workspace config file cannot le loaded: ${configPath}`
-      + `\n${error instanceof Error ? error.message : error}`
-    )
+      + `\n${error instanceof Error ? error.message : error}`,
+    );
   }
 
   cachedWorkspaces.set(level, workspace);

packages/angular/pwa/pwa/index_spec.ts

@@ -9,8 +9,6 @@ import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/te
 import * as path from 'path';
 import { Schema as PwaOptions } from './schema';
 
-
-// tslint:disable:max-line-length
 describe('PWA Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@angular/pwa',

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts

@@ -21,7 +21,6 @@ export interface HashFormat {
 }
 
 export function getOutputHashFormat(option: string, length = 20): HashFormat {
-  /* tslint:disable:max-line-length */
   const hashFormats: { [option: string]: HashFormat } = {
     none: { chunk: '', extract: '', file: '', script: '' },
     media: { chunk: '', extract: '', file: `.[hash:${length}]`, script: '' },
@@ -38,7 +37,6 @@ export function getOutputHashFormat(option: string, length = 20): HashFormat {
       script: `.[hash:${length}]`,
     },
   };
-  /* tslint:enable:max-line-length */
   return hashFormats[option] || hashFormats['none'];
 }
 

packages/angular_devkit/build_optimizer/src/build-optimizer/build-optimizer_spec.ts

@@ -54,7 +54,6 @@ describe('build-optimizer', () => {
         }());
         var RenderType_MdOption = ɵcrt({ encapsulation: 2, styles: styles_MdOption});
       `;
-      // tslint:disable:max-line-length
       const output = tags.oneLine`
         import { __extends } from "tslib";
         ${imports}

packages/angular_devkit/build_optimizer/src/build-optimizer/webpack-plugin.ts

@@ -10,8 +10,8 @@ import { Compiler } from 'webpack';  // tslint:disable-line:no-implicit-dependen
 
 export class BuildOptimizerWebpackPlugin {
   apply(compiler: Compiler) {
-    compiler.hooks.normalModuleFactory.tap("BuildOptimizerWebpackPlugin", nmf => {
-      nmf.hooks.module.tap("BuildOptimizerWebpackPlugin", (module, data) => {
+    compiler.hooks.normalModuleFactory.tap('BuildOptimizerWebpackPlugin', nmf => {
+      nmf.hooks.module.tap('BuildOptimizerWebpackPlugin', (module, data) => {
         const resolveData = data.resourceResolveData;
         if (resolveData && resolveData.descriptionFileData) {
           // Only TS packages should use Build Optimizer.

packages/angular_devkit/build_optimizer/src/transforms/import-tslib_spec.ts

@@ -32,7 +32,6 @@ describe('import-tslib', () => {
   });
 
   it('replaces wrapped __extends', () => {
-    // tslint:disable:max-line-length
     const input = tags.stripIndent`
     export default function appGlobal() {
         var __extends = (this && this.__extends) || function (d, b) {
@@ -61,7 +60,6 @@ describe('import-tslib', () => {
           return c > 3 && r && Object.defineProperty(target, key, r), r;
       };
     `;
-    // tslint:enable:max-line-length
     const output = tags.stripIndent`
       import { __decorate } from "tslib";
     `;
@@ -71,13 +69,11 @@ describe('import-tslib', () => {
   });
 
   it('replaces __metadata', () => {
-    // tslint:disable:max-line-length
     const input = tags.stripIndent`
       var __metadata = (this && this.__metadata) || function (k, v) {
           if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
       };
     `;
-    // tslint:enable:max-line-length
     const output = tags.stripIndent`
       import { __metadata } from "tslib";
     `;

packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts

@@ -262,7 +262,7 @@ function findTs2_3EnumIife(
       || !ts.isBinaryExpression(statement.expression)
       || !ts.isElementAccessExpression(statement.expression.left)
     ) {
-      return null
+      return null;
     }
 
     const leftExpression = statement.expression.left.expression;

packages/angular_devkit/schematics/tools/workflow/node-workflow.ts

@@ -34,7 +34,7 @@ export class NodeWorkflow extends workflow.BaseWorkflow {
 
       force: options.force,
       dryRun: options.dryRun,
-      registry: options.registry
+      registry: options.registry,
     });
 
     engineHost.registerTaskExecutor(

packages/angular_devkit/schematics_cli/bin/schematics.ts

@@ -24,7 +24,7 @@ import {
   DryRunEvent,
   SchematicEngine,
   UnsuccessfulWorkflowExecution,
-  formats
+  formats,
 } from '@angular-devkit/schematics';
 import { NodeModulesEngineHost, NodeWorkflow, validateOptionsWithSchema } from '@angular-devkit/schematics/tools';
 import * as inquirer from 'inquirer';

packages/ngtools/webpack/src/transformers/ctor-parameters.ts

@@ -19,7 +19,6 @@ export function downlevelConstructorParameters(
 
 // The following is sourced from tsickle with local modifications
 // Only the creation of `ctorParameters` is retained
-// tslint:disable-next-line:max-line-length
 // https://github.com/angular/tsickle/blob/0ceb7d6bc47f6945a6c4c09689f1388eb48f5c07/src/decorator_downlevel_transformer.ts
 //
 

packages/ngtools/webpack/src/transformers/ctor-parameters_spec.ts

@@ -52,12 +52,14 @@ describe('Constructor Parameter Transformer', () => {
       }
     `;
 
+    // tslint:disable:max-line-length
     const output = `
       import * as tslib_1 from "tslib";
       let RootProvidedService = class RootProvidedService { constructor() { } };
       RootProvidedService = tslib_1.__decorate([ Injectable({ providedIn: 'root' }) ], RootProvidedService);
       export { RootProvidedService }; export class MyService { constructor(v) { } } MyService.ctorParameters = () => [ { type: RootProvidedService } ];
     `;
+    // tslint:enable:max-line-length
 
     const result = transform(input);
 

packages/ngtools/webpack/src/transformers/import_factory_spec.ts

@@ -81,15 +81,13 @@ describe('@ngtools/webpack transformers', () => {
         }];
       `;
 
-      // tslint:disable: max-line-length
       const output = tags.stripIndent`
         const ɵ0 = () => import("./shared/path/to/lazy/lazy.module.ngfactory").then(m => m.LazyModuleNgFactory);
         const routes = [{
           path: 'lazy',
           loadChildren: ɵ0
         }];
       `;
-      // tslint:enable: max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input, additionalFiles, true);
       const transformer = importFactory(() => { }, () => program.getTypeChecker());

packages/ngtools/webpack/src/transformers/replace_bootstrap_spec.ts

@@ -26,7 +26,6 @@ describe('@ngtools/webpack transformers', () => {
         platformBrowserDynamic().bootstrapModule(AppModule);
       `;
 
-      // tslint:disable:max-line-length
       const output = tags.stripIndent`
         import { enableProdMode } from '@angular/core';
         import { environment } from './environments/environment';
@@ -39,7 +38,6 @@ describe('@ngtools/webpack transformers', () => {
         }
         __NgCli_bootstrap_2.platformBrowser().bootstrapModuleFactory(__NgCli_bootstrap_1.AppModuleNgFactory);
       `;
-      // tslint:enable:max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input);
       const transformer = replaceBootstrap(

packages/ngtools/webpack/src/transformers/replace_server_bootstrap_spec.ts

@@ -27,7 +27,6 @@ describe('@ngtools/webpack transformers', () => {
         platformDynamicServer().bootstrapModule(AppModule);
       `;
 
-      // tslint:disable:max-line-length
       const output = tags.stripIndent`
         import { enableProdMode } from '@angular/core';
         import { environment } from './environments/environment';
@@ -40,7 +39,6 @@ describe('@ngtools/webpack transformers', () => {
         }
         __NgCli_bootstrap_2.platformServer().bootstrapModuleFactory(__NgCli_bootstrap_1.AppModuleNgFactory);
       `;
-      // tslint:enable:max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input);
       const transformer = replaceServerBootstrap(
@@ -71,7 +69,6 @@ describe('@ngtools/webpack transformers', () => {
         });
       `;
 
-      // tslint:disable:max-line-length
       const output = tags.stripIndent`
         import { enableProdMode } from '@angular/core';
         import { environment } from './environments/environment';
@@ -87,7 +84,6 @@ describe('@ngtools/webpack transformers', () => {
             url: '/'
           });
       `;
-      // tslint:enable:max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input);
       const transformer = replaceServerBootstrap(
@@ -120,7 +116,6 @@ describe('@ngtools/webpack transformers', () => {
         }));
       `;
 
-      // tslint:disable:max-line-length
       const output = tags.stripIndent`
         import * as express from 'express';
 
@@ -140,7 +135,6 @@ describe('@ngtools/webpack transformers', () => {
           bootstrap: __NgCli_bootstrap_1.AppModuleNgFactory
         }));
       `;
-      // tslint:enable:max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input);
       const transformer = replaceServerBootstrap(
@@ -168,7 +162,6 @@ describe('@ngtools/webpack transformers', () => {
         platformDynamicServer().bootstrapModule(AppModule);
       `;
 
-      // tslint:disable:max-line-length
       const output = tags.stripIndent`
         import { enableProdMode } from '@angular/core';
         import { environment } from './environments/environment';
@@ -181,7 +174,6 @@ describe('@ngtools/webpack transformers', () => {
         }
         __NgCli_bootstrap_2.platformServer().bootstrapModuleFactory(__NgCli_bootstrap_1.AppModuleNgFactory);
       `;
-      // tslint:enable:max-line-length
 
       const { program, compilerHost } = createTypescriptContext(input);
       const transformer = replaceServerBootstrap(

packages/schematics/angular/application/index_spec.ts

@@ -12,7 +12,6 @@ import { getFileContent } from '../utility/test';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
 import { Schema as ApplicationOptions, Style, ViewEncapsulation } from './schema';
 
-// tslint:disable:max-line-length
 describe('Application Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/angular',

packages/schematics/angular/component/index_spec.ts

@@ -12,7 +12,6 @@ import { createAppModule } from '../utility/test';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
 import { ChangeDetection, Schema as ComponentOptions, Style } from './schema';
 
-// tslint:disable:max-line-length
 describe('Component Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/angular',
@@ -273,7 +272,6 @@ describe('Component Schematic', () => {
     const tree = await schematicRunner.runSchematicAsync('component', options, appTree).toPromise();
     const content = tree.readContent('/projects/bar/src/app/app.module.ts');
     expect(content).toMatch(
-      // tslint:disable-next-line:max-line-length
       /import { TestComponentComponent } from '\.\/dir\/test-component\/test-component.component'/,
     );
   });
@@ -288,7 +286,6 @@ describe('Component Schematic', () => {
 
     const content = appTree.readContent('/projects/bar/src/app/admin/module/module.module.ts');
     expect(content).toMatch(
-      // tslint:disable-next-line:max-line-length
       /import { TestComponentComponent } from '..\/..\/other\/test-component\/test-component.component'/,
     );
   });

packages/schematics/angular/directive/index_spec.ts

@@ -10,7 +10,6 @@ import { Schema as ApplicationOptions } from '../application/schema';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
 import { Schema as DirectiveOptions } from './schema';
 
-// tslint:disable:max-line-length
 describe('Directive Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/angular',

packages/schematics/angular/library/index_spec.ts

@@ -17,7 +17,6 @@ function getJsonFileContent(tree: UnitTestTree, path: string) {
   return JSON.parse(tree.readContent(path));
 }
 
-// tslint:disable:max-line-length
 describe('Library Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/ng_packagr',

packages/schematics/angular/migrations/update-6/index.ts

@@ -556,7 +556,6 @@ function extractProjectsConfig(
 
       const e2eTargets: JsonObject = {};
 
-      // tslint:disable-next-line:max-line-length
       const protractorConfig = config && config.e2e && config.e2e.protractor && config.e2e.protractor.config
         ? config.e2e.protractor.config
         : '';

packages/schematics/angular/migrations/update-8/differential-loading.ts

@@ -20,7 +20,6 @@ import {
   removePropertyInAstObject,
 } from '../../utility/json-utils';
 
-// tslint:disable-next-line:max-line-length
 const browserslistContent = `# This file is used by the build system to adjust CSS and JS output to support the specified browsers below.
 # For additional information regarding the format and rule options, please see:
 # https://github.com/browserslist/browserslist#queries

packages/schematics/angular/migrations/update-9/update-workspace-config_spec.ts

@@ -28,28 +28,28 @@ const scriptsWithLazy = [
   { bundleName: 'two', input: 'two.js', lazy: true },
   { bundleName: 'tree', input: 'tree.js' },
   'four.js',
-]
+];
 
 const scriptsExpectWithLazy = [
   { bundleName: 'one', input: 'one.js' },
   { bundleName: 'two', inject: false, input: 'two.js' },
   { bundleName: 'tree', input: 'tree.js' },
   'four.js',
-]
+];
 
 const stylesWithLazy = [
   { bundleName: 'one', input: 'one.css', lazy: false },
   { bundleName: 'two', input: 'two.css', lazy: true },
   { bundleName: 'tree', input: 'tree.css' },
   'four.css',
-]
+];
 
 const stylesExpectWithLazy = [
   { bundleName: 'one', input: 'one.css' },
   { bundleName: 'two', inject: false, input: 'two.css' },
   { bundleName: 'tree', input: 'tree.css' },
   'four.css',
-]
+];
 
 const workspacePath = '/angular.json';
 

packages/schematics/angular/module/index_spec.ts

@@ -10,7 +10,6 @@ import { Schema as ApplicationOptions } from '../application/schema';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
 import { Schema as ModuleOptions } from './schema';
 
-// tslint:disable:max-line-length
 describe('Module Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/angular',

packages/schematics/angular/service-worker/index_spec.ts

@@ -93,7 +93,6 @@ describe('Service Worker Schematic', () => {
     const tree = await schematicRunner.runSchematicAsync('service-worker', defaultOptions, appTree)
       .toPromise();
     const pkgText = tree.readContent('/projects/bar/src/app/app.module.ts');
-    // tslint:disable-next-line:max-line-length
     const expectedText = 'ServiceWorkerModule.register(\'ngsw-worker.js\', { enabled: environment.production })';
     expect(pkgText).toContain(expectedText);
   });

packages/schematics/angular/service/index_spec.ts

@@ -10,7 +10,6 @@ import { Schema as ApplicationOptions } from '../application/schema';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
 import { Schema as ServiceOptions } from './schema';
 
-// tslint:disable:max-line-length
 describe('Service Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@schematics/angular',

packages/schematics/angular/universal/index_spec.ts

@@ -93,7 +93,7 @@ describe('Universal Schematic', () => {
         module: 'commonjs',
       },
       files: [
-        "src/main.server.ts"
+        'src/main.server.ts',
       ],
       angularCompilerOptions: {
         entryModule: './src/app/app.server.module#AppServerModule',
@@ -117,7 +117,7 @@ describe('Universal Schematic', () => {
         module: 'commonjs',
       },
       files: [
-        "src/main.server.ts"
+        'src/main.server.ts',
       ],
       angularCompilerOptions: {
         entryModule: './src/app/app.server.module#AppServerModule',