Skip to content

addons property missing in angular-cli.json #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookhutchinson opened this issue Jan 21, 2017 · 8 comments
Closed

addons property missing in angular-cli.json #4146

brookhutchinson opened this issue Jan 21, 2017 · 8 comments

Comments

@brookhutchinson
Copy link

brookhutchinson commented Jan 21, 2017

Please provide us with the following information:

OS?

Windows 10

Versions.

[email protected]

Repro steps.

The "addons" property is missing from angular-cli.json

Help me understand where I need to define the font-awesome fonts file path since the "adons" property no longer exists.

The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.


Thanks! We'll be in touch soon.

@clydin
Copy link
Member

clydin commented Jan 21, 2017

This is intentional.

See: #4052

@brookhutchinson
Copy link
Author

My angular-cli project is using font-awesome along with Bootstrap 4. The angular-cli setup instructions include defining the fonts path inside the "addOns" property. Since angular-cli.json no longer has a "addOns" property by default should the property be added back? Should I just add the "addOns" property in my project? Or should I define the font-awesome fonts path inside a different angular-cli.json property?

@clydin
Copy link
Member

clydin commented Jan 21, 2017

The instructions (https://github.com/angular/angular-cli#global-library-installation) reference apps not addons. The addons property is reserved for future use.

@filipesilva
Copy link
Contributor

Closing as @clydin has answered.

@brookhutchinson
Copy link
Author

Respectfully I think that I need a more specific answer since there are multiple properties under the "apps" property inside angular-cli.json

Here is what I want to do. Have the angular-cli inject both the font-awesome.css and the font-awesome file path that is used for font-awesome icons. I have included the font-awesome.min.css with no problem using the "styles" property under the "apps" property.

"styles": [ "../node_modules/bootstrap/dist/css/bootstrap.min.css", "../node_modules/font-awesome/css/font-awesome.min.css", "app/css/styles.css" ],

Help me understand where I need to define the font-awesome fonts file path since the "adons" property no longer exists. I understand that the suggestion is to define the value under the "apps" property. Help me understand on what property under the "apps" property.

Here is the old way that I was referencing the font-awesome fonts file path using the "addons" property
"addons": [ "../node_modules/font-awesome/fonts/*.+(otf|eot|svg|ttf|woff|woff2)" ],

@clydin
Copy link
Member

clydin commented Jan 21, 2017

The 'addons' field is simply a placeholder. It provides no functionality.
Adding the stylesheet to 'styles' is all that is needed.
See: https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/include-font-awesome.md

@brookhutchinson brookhutchinson changed the title addOns Property Missing in angular-cli.json addons property missing in angular-cli.json Jan 21, 2017
@scottseeker
Copy link

scottseeker commented Aug 3, 2017

@clydin Are you saying the reference to the font files doesn't need to be in the config file at all? @brookhutchinson is asking you about where the addons include of font files should end up in the 'apps' structure. He's not asking about the styles.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants