Skip to content

Move reflect-metadata to a peer dependancy #3342

Closed
@waterfoul

Description

@waterfoul

OS?

All

Versions.

All versions after 1.0.0-beta.20-1

Repro steps.

Look at the package.json in an installed angular-cli

The log given by the failure.

Mention any other details that might be useful.

If two modules import different versions of this module it will cause some very confusing errors. By including it as a peer npm will output a warning upon detecting a version mismatch and will only install the newer of the mismatched versions. Situations like this is the whole reason the concept of peer dependencies exists

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussioneffort1: easy (hours)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions