Router outlet broken

[filipesilva]

The last two commits (e2c8795 and 2efc9a1) seem to have broken the router. Somehow, ngOnInit events on child routes are not firing.

Undoing these commits causes them to fire again. I suspect this might be the issue, in that dependencies are loaded out of order ( previous order ) and thus cause parts of angular to not have the required dependencies.

/cc @cironunes @jkuri

[jkuri]

Hi, do you maybe have any example ready to test with?

[jkuri]

Maybe just Rx should be loaded before Angular2, can you check please?

[filipesilva]

I ran into this with routes generated via #139. The ngOnInit on hero-detail.component.ts and hero-list.component.ts (assuming you use ng generate route hero) do not work with those two commits.

I am unsure of how to just load Rx before the rest with broccoli though, how do I do it?

[jkuri]

Just add this line before **/angular2.dev.js. Then try to generate routes again.

[filipesilva]

That did not work.

I used the order on the quickstart and it works:

      inputFiles: [
        // '**/es6-shim.js',
        '**/system-polyfills.js',
        '**/angular2-polyfills.js',
        '**/system.src.js',
        '**/Rx.js',
        '**/angular2.dev.js',
        '**/http.dev.js',
        '**/router.dev.js',
        '**/upgrade.dev.js'
      ],

...except that the es6-shim errors. If I take it out it's fine.

I can't see why it would error though, since its whole purpose is the be the very first think so it can shim missing functionality.

[jkuri]

Okay, then just add this fix to your PR. I will check about es6-shim errors
asap.

On Monday, 1 February 2016, Filipe Silva notifications@github.com wrote:

That did not work.

I used the order on the quickstart
https://angular.io/docs/ts/latest/quickstart.html#!%23add-the-index-html-
and it works:

  inputFiles: [
    // '**/es6-shim.js',
    '**/system-polyfills.js',
    '**/angular2-polyfills.js',
    '**/system.src.js',
    '**/Rx.js',
    '**/angular2.dev.js',
    '**/http.dev.js',
    '**/router.dev.js',
    '**/upgrade.dev.js'
  ],

...except that the es6-shim errors. If I take it out it's fine.

I can't see why it would error though, since its whole purpose is the be
the very first think so it can shim missing functionality.

—
Reply to this email directly or view it on GitHub
#166 (comment)
.

[filipesilva]

Tried adding the shim separately, outside vendor.js and it works fine.

I'd prefer not to change up that order from within my PR because it's not related to routes per se, but rather to dependency loading.

I'll gladly open up a new PR for it though, but might as well also fix the shim thing.

[jkuri]

Hi @filipesilva. Is this working now?

[filipesilva]

No, still has the problem with the shim being loaded via broccolli. I haven't had time to look into it more.

[jkuri]

Please try the following order, if it works for you;

inputFiles: [
  '**/angular2-polyfills.js',
  '**/system.src.js',
  '**/system-polyfills.js',
  '**/es6-shim.js',
  '**/Rx.js',
  '**/angular2.dev.js',
  '**/http.dev.js',
  '**/router.dev.js',
  '**/upgrade.dev.js',
],

if its okay please provide PR with the fix, otherwise please tell me how to reproduce an error.

[cironunes]

any news?

[filipesilva]

@jkuri just tried the order you said, still does not work.

We have to follow the order in the guides though: es6-shim.js needs to be the first one, system-polyfills.js before system, etc. Otherwise those files aren't doing anything.

To reproduce, do the following:

ng new testproj
cd testproj
npm link angular-cli
ng g route hero
// follow the instructions on readme, line 95 to add the route
ng serve
// open browser on http://localhost:4200/hero

This is what appears:

Now open angular-cli/lib/broccoli/angular2-app.js and change lines 59-69 to have the order indicated in the quickstart:

      inputFiles: [ //TODO: figure out how to make it a glob that maintains the order of the files
        '**/es6-shim.js',
        '**/system-polyfills.js',
        '**/angular2-polyfills.js',
        '**/system.src.js',
        '**/Rx.js',
        '**/angular2.dev.js',
        '**/http.dev.js',
        '**/router.dev.js',
        '**/upgrade.dev.js'
      ],

Stop and restart ng serve. Browser should have an error:

Comment out the es6-shim.js line, stop and restart ng serve. Browser will show the correct result:

[jkuri]

@filipesilva thanks for helping with reproduce, I got same errors.
Solved it with this order;

'**/angular2-polyfills.js',
'**/es6-shim.js',
'**/system-polyfills.js',
'**/system.src.js',
'**/Rx.js',
'**/angular2.dev.js',
'**/http.dev.js',
'**/router.dev.js',
'**/upgrade.dev.js'

I think adding '**/angular2-polyfills.js' before all others is the key (not sure). Please check.