@angular/pwa noscript fallback missing

[markgoho]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Area

- [X] devkit
- [ ] schematics

Versions

Repro steps

ng add @angular/pwa

Desired functionality

in the index.html file, we should see
<noscript>Please enable JavaScript to continue using this application.</noscript>

Mention any other details that might be useful

This code was merged in on May 21: angular/devkit#853 by @filipesilva but has somehow been lost in the shuffle.

[markgoho]

It looks like the code is still there:

angular-cli/packages/angular/pwa/pwa/index.ts

Line 100 in 44086c6

= '<noscript>Please enable JavaScript to continue using this application.</noscript>';

and the spec file:

angular-cli/packages/angular/pwa/pwa/index_spec.ts

Line 97 in 44086c6

.toMatch(/<noscript>Please enable JavaScript to continue using this application.<\/noscript>/);

However, the index.html file is not being updated with this line.

[Brocco]

I agree that the code and test appear to be OK, perhaps it is how we are parsing the index.html file in order to determine where to place this text.

Can you please share the contents of your index.html file for testing?

Thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}