Skip to content

fix(ui-sref): replace raw href modification with attrs.$set #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2014
Merged

fix(ui-sref): replace raw href modification with attrs.$set #1300

merged 1 commit into from
Aug 28, 2014

Conversation

@nikaspran
Copy link
Contributor

@nikaspran nikaspran commented Aug 28, 2014

Fix #1171

christopherthielen added a commit that referenced this pull request Aug 28, 2014
@christopherthielen
Merge pull request #1300 from nikaspran/ui-sref-set-href
0bb5f91 
fix(uiSref): replace raw href modification with attrs.$set
@christopherthielen christopherthielen merged commit 0bb5f91 into angular-ui:master Aug 28, 2014
@christopherthielen
Copy link
Contributor

christopherthielen commented Aug 28, 2014

Thanks

@christopherthielen christopherthielen added this to the 0.3.0 milestone Aug 28, 2014
@christopherthielen christopherthielen modified the milestones: 0.2.12, 0.3.0 Sep 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2.12

Development

Successfully merging this pull request may close these issues.

ui-sref should use $set instead of raw access to set href

2 participants

@nikaspran @christopherthielen