-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Milestone
Description
Plugins can depend on ui-router-core
. However, when using the prebuilt UMD bundles, ui-router-core
is bundled together with the angularjs code. When a plugin tries to use something from ui-router-core
, the module is not found as nothing is found in the global scope.
There are two options I've considered:
-
Split up the UMD modules. Publish only the AngularJS bits in
angular-ui-router.min.js
, and force ui-router users to also add theui-router-core.min.js
UMD bundle when they upgrade. -
Add an adapter that re-exports the core bits and is published as
core-adapter.umd.js
I'm going move with option 2 because I don't want to force all existing users who are used to a monolithic bundle to now explicitly include ui-router-core too.
Metadata
Metadata
Assignees
Labels
No labels