Redirecting to state with no URL in transition hook ignores location=false

[smhc]

I have a login state with no URL specified. The idea is when navigating to a given state they will be redirected to the login state if they aren't logged in. The URL shouldn't be updated in this case - it should reflect the intended state. If they login, the state is synced with the url via $urlRouter.sync().

However what is happening is:

redirect to login
transition login Object {
    location: "replace", 
    relative: null, 
    inherit: true, 
    notify: false, 
    current:
    custom:
    inherit: true
    location: "replace"
    notify: false
    redirectedFrom: Transition
    relative: null
    reload: false
    reloadState: undefined
    source: "redirect"
passing through 
transition home Object {
    location: true,
    relative: null,
    inherit: true,
    notify: true,
    current: 
    custom: 
    inherit: true
    location: true
    notify: true
    relative: null
    reload: false
    reloadState: undefined
    source: "url"
redirect to login
transition login Object {
    location: "replace", 
    relative: null,
    inherit: true,
    notify: false,
    current:
    custom:
    inherit: true
    location: "replace"
    notify: false
    redirectedFrom: Transition
    relative: null
    reload: false
    reloadState: undefined
    source: "redirect"
passing through 

The redirect is using code similar to:

return $state.target('login', [], { custom: { xx: 'asdf'} , notify: false, location: false });

But location is being set to 'replace'. Because the login state doesn't have a URL, it is being set to '/', which modifies the URL, losing the intended url and causing extra state redirects (intended -> login -> / -> login)

(ui router v1.0.0-rc.1, angular 1.6.1)

[smhc]

I made the following change and got the behaviour I wanted. Not sure if it is correct however:

        var rejectedTransitionHandler = function (transition) { return function (error) {
            if (error instanceof Rejection) {
                if (error.type === exports.RejectType.IGNORED) {
                    // Consider ignored `Transition.run()` as a successful `transitionTo`
                    if (transition._targetState._options.location) {
                        router.urlRouter.update();
                    }
                    return services.$q.when(globals.current);
                }

An alternative is:

                    if (transition._targetState._definition.url !== null) {
                        router.urlRouter.update();
                    }

[christopherthielen]

I have a login state with no URL specified. The idea is when navigating to a given state they will be redirected to the login state if they aren't logged in. The URL shouldn't be updated in this case - it should reflect the intended state. If they login, the state is synced with the url via $urlRouter.sync().

Sounds like what we're doing in the sample app:
https://ui-router.github.io/sample-app-ng1/#/mymessages/inbox/5648b50cc586cac4aed6836f

https://github.com/ui-router/sample-app-ng1/blob/8604ca2c7c7d5ac4db8ed3a96c1f3b8825b722dd/app/global/requiresAuth.hook.js#L18-L24

  // Function that returns a redirect for the current transition to the login state
  // if the user is not currently authenticated (according to the AuthService)

  let redirectToLogin = (transition) => {
    let AuthService = transition.injector().get('AuthService');
    let $state = transition.router.stateService;
    if (!AuthService.isAuthenticated()) {
      return $state.target('login', undefined, { location: false });
    }
  };

[christopherthielen]

@smhc Do you notice anything missing in this block of code? ;)

https://github.com/ui-router/core/blob/afdeec286b68a5df5d74b7093f682354c40e26ef/src/transition/transition.ts#L518-L523

    // If the original transition was caused by URL sync, then use { location: 'replace' }
    // on the new transition (unless  the target state explicitly specifies location)
    if (this.options().source === 'url') {
      redirectOpts.location = 'replace';
    }

[smhc]

I think this ended up being a problem on my end. I was navigating to "#/xxx" instead of "#!/xxx". I believe this changed with angular 1.6.

This caused extra redirects and URL syncs. I'm not sure if it's still a bug, but I have worked around it by using #! in the URLs. Of course anyone that has an old bookmark with the '#/xx' style URL will get bounced back to '#!/' if they tried to use it while not logged in.

[christopherthielen]

'#/xx' style URL will get bounced back to '#!/' if they tried to use it while not logged in.

You could have changed the location prefix back to empty string

$locationProvider.hashPrefix("")

Your bug report is valid, the sample app location: false is not being respected with rc.1

[smhc]

I have a strong suspicion this fix is causing state transitions via url changes to result in the url to be modified despite the state transition being rejected. (#3416)

[christopherthielen]

@smhc can you elaborate? The url isn't being reset to the previous when the transition is rejected?

[smhc]

Yes that's right. When changing the URL via the address bar or a bookmark and the state transition is rejected via UiCanExit() returning false. In this scenario the URL does not get restored to the original. I suppose it could also happen when hitting 'back' or 'forward' in the browser.

e.g:

URL and state at: /home/phone
Change to "/" via the address bar
UICanExit() for home/phone returns false
URL now reflects "/" but the application state stays at 'home/phone'.

It works ok when changing state via the application. But in this case the URL never gets a chance to change.

[smhc]

Looks like a similar issue to : #3403
It seems to occur when uiCanExit returns a promise that either rejects or resolves to false.