Skip to content

fix(rz-vertical rz-tick-value): Position long labels on vertical sliders correctly #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2016
Merged

fix(rz-vertical rz-tick-value): Position long labels on vertical sliders correctly #306

merged 1 commit into from
Apr 1, 2016

Conversation

dbartholomae
Copy link

Fixes #305

I manually checked whether this works by using the same change on http://angular-slider.github.io/angularjs-slider/
But given that I don't now the code base that well and style changes are not covered by tests, you might want to check this again.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #306 into master will not affect coverage as of e19c151

@@            master    #306   diff @@
======================================
  Files            1       1       
  Stmts          701     701       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            701     701       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of e19c151

Powered by Codecov. Updated on successful CI builds.

@ValentinH
Copy link
Member

Thanks for taking care of this.

30px looks too far to me, I would use left: 24px. What do you think?

Here's a demo with you code: http://jsfiddle.net/y57c3bco/

@dbartholomae
Copy link
Author

Personally I would prefer a little more spacing (left: 30px). For backwards compatibility you might want to choose 22px though, as this seems to correspond to the old positioning :)

@ValentinH
Copy link
Member

Indeed, the goal is to keep the same style as before and to have the same space for horizontal and vertical sliders.

Then you can still override the value in your custom CSS ;)

@dbartholomae
Copy link
Author

Forcepushed the change to 22px to this branch :)

@ValentinH
Copy link
Member

Great thanks ;)

@ValentinH ValentinH merged commit 30d82df into angular-slider:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants