-
-
Notifications
You must be signed in to change notification settings - Fork 497
Allow to show less ticks than steps and allow to hide pointer labels #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you please set up a JSFiddle showing what feature you have added? |
Here it is: http://jsfiddle.net/fofi/7au7vsL6/1/ |
@@ -595,14 +602,12 @@ function throttle(func, wait, options) { | |||
this.hideEl(this.ceilLab); | |||
} | |||
|
|||
if(this.showTicksValue) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this part? This will break existing implementations...
The Btw, I have started some work on the latest version to add the same feature: #264 |
Hi, About the true/false stuff, at least in this version, that occurs to every attribute, and I was not going to fix all that for now, I just add it like it was. This probably is due to the directive version we are using, and we will try to upgrade as soon as possible. |
Do you use NPM to grab this library code? |
Not at the moment, so i think its okey. |
If you don't use it, I would prefer that you use your patched version directly and not update the legacy 1.1.X version. I only keep it in case of a major bug being discovered but I don't want to add new feature to it. |
This allow to add step for ticks in case you want less than steps.
It also add an attribute to hide pointer labels, before always hide pointer labels when tick labels were shown.