Skip to content

Allow to show less ticks than steps and allow to hide pointer labels #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

fofi
Copy link

@fofi fofi commented Mar 9, 2016

This allow to add step for ticks in case you want less than steps.
It also add an attribute to hide pointer labels, before always hide pointer labels when tick labels were shown.

@ValentinH
Copy link
Member

Could you please set up a JSFiddle showing what feature you have added?

@fofi
Copy link
Author

fofi commented Mar 9, 2016

Here it is: http://jsfiddle.net/fofi/7au7vsL6/1/

@@ -595,14 +602,12 @@ function throttle(func, wait, options) {
this.hideEl(this.ceilLab);
}

if(this.showTicksValue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this part? This will break existing implementations...

@ValentinH
Copy link
Member

The rz-slider-hide-pointer-labels doesn't handle true/false values. If you set false, then the pointer labels are hidden which is not what I would expect.

Btw, I have started some work on the latest version to add the same feature: #264

@fofi
Copy link
Author

fofi commented Mar 10, 2016

Hi,
that part of code, auto hide all labels when tick labels were active, so I added the rz-slider-hide-pointer-labels to control it.

About the true/false stuff, at least in this version, that occurs to every attribute, and I was not going to fix all that for now, I just add it like it was.
The directive get it 'true' as string and this make value = !!"false", so that ends in true because the string exist.

This probably is due to the directive version we are using, and we will try to upgrade as soon as possible.

@ValentinH
Copy link
Member

Do you use NPM to grab this library code?

@fofi
Copy link
Author

fofi commented Mar 10, 2016

Not at the moment, so i think its okey.

@ValentinH
Copy link
Member

If you don't use it, I would prefer that you use your patched version directly and not update the legacy 1.1.X version. I only keep it in case of a major bug being discovered but I don't want to add new feature to it.

@ValentinH ValentinH closed this Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants