-
-
Notifications
You must be signed in to change notification settings - Fork 497
feat(ticks): Accept numbers for showTicks/showTicksValues #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is
|
Nice work! The UX that I've seen used elsewhere is a bit different. The tick value is below and the slider tick value is shown above as it is dragged. It hides when the mouse is not over it. http://take.ms/aenJI - with the mouse over the slider (shows the value above) I can also click on the values below the line to set the slider value. |
In my opinion, hiding the value when the mouse is not on the slider is not an option since it is important for the slider to be fully understandable without any additional widgets. Thanks to CSS, ticks can already been set on the bottom but the slider need to work properly for ticks with top and bottom. |
Sure, I agree with you - I don't like hidden UX. |
8a03de4
to
0ad91f8
Compare
@lookfirst I have updated the demo and add handling for showTicksValues. Can I get your feedback please? |
👍 |
Ok then I just need to complete to unit tests. |
Any ETA for the release which contains this feature? We just so happened to need it and saw it was being implemented. |
Normally, the feature is ready, only the unit tests are missing. I just need to find the time to write them... Does the demo looks good to you? |
Thanks to this feature, you can display ticks at intermediate positions without setting a fixed step
e08422c
to
76f1ef5
Compare
Just integrated this into my app... thanks! screenshot: http://take.ms/RIYCH |
Great! :) |
Thanks to this feature, you can display ticks at intermediate positions without setting a fixed step.
As requested in #259.
Demo: http://jsfiddle.net/xaa0qox1/
A few problems found so far:
showTicksValues
, the pointer label is hidden and so we don't really know the current value. This is because when theshowTicks*
options were only boolean, the labels were useless since they were replaced by the ticks values.