Skip to content

add dest and add option to cli #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Hypercubed
Copy link

@Hypercubed Hypercubed commented Apr 8, 2022

Please consider adding the dest and add options to the cli.

@JohannesHoppe
Copy link
Member

Thank you very much for pushing this feature. I will review this on Monday! 🙂👍

@Hypercubed
Copy link
Author

@JohannesHoppe Anything you need from me?

@fmalcher
Copy link
Member

fmalcher commented Jun 17, 2022

@Hypercubed Thanks for your patience! Lots of things going on here at the moment …
Thanks for your contribution which I think makes sense. The only thing that's missing is documentation. Can you please add the new options to the Standalone README? That will help a lot!

@fmalcher
Copy link
Member

fmalcher commented Jun 17, 2022

One thing that's still open for discussion:
You only added the options to the standalone variant. I think we should also make them available for the Angular CLI builder. Is there any reason why we should NOT do this?

@JohannesHoppe
Copy link
Member

yes, I actually don't need this feature, but there would certainly be a good usecase. However, it needs to be well documented so that people don't get confused with dist and dest.

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Jan 26, 2024

I added a --dir option in [email protected]. Please try out this version and give me feedback.

This option overrides the directory for all published sources, relative to the current working directory. The normal logic with buildTargets and conventions is ignored in this case.

See #179

Do you still need dest and add, if yes, please comment here so that I can reopen this issue! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants