Unit tests for issue #149 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SethDavenport @danielfigueiredo related to an issue a user raised - any idea? made some tests to reproduce the issue. Initially I thought it might have been something related to the angular lifecycle hooks, but was able to reproduce it outside of angular. |
| this._store.subscribe(() => this._store$.next(this._store.getState())); | ||
| let x = store as any; | ||
|
|
||
| this._store$ = Observable.from(x); //new BehaviorSubject(store.getState()); |
There was a problem hiding this comment.
@SethDavenport was looking at the interop unit tests from redux
this seems to fix the issue, although still bugging me to what the problem was with the BehaviorSubject
There was a problem hiding this comment.
Weird - I wonder if there's a subtle difference in 'zoning' between the two ways of creating observables.
e-schultz
force-pushed
the
bug-action-dispatch-order
branch
2 times, most recently
from
69a2d60 to
9b49d6e
Compare
added 2 commits
July 19, 2016 16:55
* fix angular-redux#149 - chained actions should not get stale state, changed to create an observable from redux since redux 3.4x supports an observable shim * fix angular-redux#138 - ability to use select decorators in service Changing to use redux's observable, had to change how we created the initial observable. Use switchMap to switch streams once the store observable becomes available
e-schultz
force-pushed
the
bug-action-dispatch-order
branch
from
2c3f554 to
381228a
Compare
added 2 commits
July 21, 2016 12:02
e-schultz
pushed a commit
that referenced
this pull request
Jul 21, 2016
Merged
e-schultz
pushed a commit
that referenced
this pull request
Jul 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.