Remove lodash as a dependency #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't solve #113 by itself though - need to to more work to understand angular-cli's weird SystemJS setup. |
SethDavenport
changed the title
SethDavenport
force-pushed
the
fix/systemjs-support
branch
from
499b49a to
d09118c
Compare
Apart from making the lib less complex, it also makes it easier to handle with SystemJS. This is important given that the Angular-CLI has embraced SystemJS instead of our usual webpack toolchain. Also rejigged the deps a bit: - typings should be a devdepedency - Angular and RxJS should be peer deps Connected to angular-redux#113
SethDavenport
force-pushed
the
fix/systemjs-support
branch
from
d09118c to
5008e3d
Compare
This is needed to match the default way Angular-CLI sets up the SystemJS import mappings for RxJs. Arguably this is the right way to do it anyway; we already switched to this in the v3.x branch.
SethDavenport
changed the title
|
Fixed up RxJS imports to not include the whole library; this is also compatible with how Angular-CLI does it. @e-schultz thoughts? |
|
👍 |
e-schultz
added a commit
that referenced
this pull request
Jul 21, 2016
Merged
e-schultz
added a commit
that referenced
this pull request
Jul 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from making the lib less complex, it also makes it easier to handle with SystemJS. This is important given that the Angular-CLI has embraced SystemJS instead of our usual Webpack toolchain.
Also rejigged the deps a bit:
Connected to #113