Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ng/directive/ngStyle.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@
</example>
*/
var ngStyleDirective = ngDirective(function(scope, element, attr) {
scope.$watch(attr.ngStyle, function ngStyleWatchAction(newStyles, oldStyles) {
scope.$watchCollection(attr.ngStyle, function ngStyleWatchAction(newStyles, oldStyles) {
if (oldStyles && (newStyles !== oldStyles)) {
forEach(oldStyles, function(val, style) { element.css(style, '');});
}
if (newStyles) element.css(newStyles);
}, true);
});
});
4 changes: 3 additions & 1 deletion src/ngResource/resource.js
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,9 @@ angular.module('ngResource', ['ng']).

function cancelRequest(value) {
promise.catch(noop);
timeoutDeferred.resolve(value);
if (timeoutDeferred !== null) {
timeoutDeferred.resolve(value);
}
}
};

Expand Down
27 changes: 27 additions & 0 deletions test/ng/directive/ngStyleSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,33 @@ describe('ngStyle', function() {
}));


it('should not deep watch objects', inject(function($rootScope, $compile) {
element = $compile('<div ng-style="{height: heightObj}"></div>')($rootScope);
$rootScope.$digest();
expect(parseInt(element.css('height') + 0, 10)).toEqual(0); // height could be '' or '0px'
$rootScope.heightObj = {toString: function() { return '40px'; }};
$rootScope.$digest();
expect(element.css('height')).toBe('40px');

element.css('height', '10px');
$rootScope.heightObj.otherProp = 123;
$rootScope.$digest();
expect(element.css('height')).toBe('10px');
}));


it('should support binding for object literals', inject(function($rootScope, $compile) {
element = $compile('<div ng-style="{height: heightStr}"></div>')($rootScope);
$rootScope.$digest();
expect(parseInt(element.css('height') + 0, 10)).toEqual(0); // height could be '' or '0px'
$rootScope.$apply('heightStr = "40px"');
expect(element.css('height')).toBe('40px');

$rootScope.$apply('heightStr = "100px"');
expect(element.css('height')).toBe('100px');
}));


it('should support lazy one-time binding for object literals', inject(function($rootScope, $compile) {
element = $compile('<div ng-style="::{height: heightStr}"></div>')($rootScope);
$rootScope.$digest();
Expand Down
19 changes: 19 additions & 0 deletions test/ngResource/resourceSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2102,6 +2102,25 @@ describe('cancelling requests', function() {

expect(creditCard.$cancelRequest).toBe(noop);
});

it('should not break when calling old `$cancelRequest` after the response arrives', function() {
$httpBackend.whenGET('/CreditCard').respond({});

var CreditCard = $resource('/CreditCard', {}, {
get: {
method: 'GET',
cancellable: true
}
});

var creditCard = CreditCard.get();
var cancelRequest = creditCard.$cancelRequest;

$httpBackend.flush();

expect(cancelRequest).not.toBe(noop);
expect(cancelRequest).not.toThrow();
});
});

describe('configuring `cancellable` on the provider', function() {
Expand Down