Skip to content

feat(nf): compatibility with @angular/build package #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions libs/mf/src/schematics/init-webpack/schematic.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import {
apply,
chain,
mergeWith,
move,
Rule,
template,
Tree,
url,
apply,
mergeWith,
template,
move,
} from '@angular-devkit/schematics';

import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
import { strings } from '@angular-devkit/core';
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
import * as json5 from 'json5';
import * as semver from 'semver';

Expand Down Expand Up @@ -234,7 +234,8 @@ export default function config(options: MfSchematicSchema): Rule {

const buildConfig = projectConfig?.architect?.build;
const isApplicationBuilder =
buildConfig?.builder === '@angular-devkit/build-angular:application';
buildConfig?.builder === '@angular-devkit/build-angular:application' ||
buildConfig?.builder === '@angular/build:application';

if (isApplicationBuilder && !options.skipConfirmation) {
console.warn(
Expand Down
25 changes: 16 additions & 9 deletions libs/native-federation/src/builders/build/builder.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as fs from 'fs';
import { existsSync, mkdirSync, rmSync } from 'fs';
import * as mrmime from 'mrmime';
import * as path from 'path';

Expand All @@ -12,10 +13,12 @@ import {
BuilderContext,
BuilderOutput,
createBuilder,
targetFromTargetString,
} from '@angular-devkit/architect';

import { normalizeOptions } from '@angular-devkit/build-angular/src/builders/dev-server/options';


import { logger, setLogLevel } from '@softarc/native-federation/build';

import { targetFromTargetString } from '@angular-devkit/architect';
Expand All @@ -24,13 +27,19 @@ import {
FederationOptions,
getExternals,
loadFederationConfig,
logger,
setBuildAdapter,
setLogLevel,
} from '@softarc/native-federation/build';
import {
createAngularBuildAdapter,
setMemResultHandler,
} from '../../utils/angular-esbuild-adapter';

import { NfBuilderSchema } from './schema';
import { RebuildHubs } from '../../utils/rebuild-events';
import { updateScriptTags } from '../../utils/updateIndexHtml';
import { JsonObject } from '@angular-devkit/core';
import { JsonObject } from '@angular-devkit/core';
import { FederationInfo } from '@softarc/native-federation-runtime';
import { PluginBuild } from 'esbuild';
Expand All @@ -42,6 +51,11 @@ import {
MemResults,
NgCliAssetResult,
} from '../../utils/mem-resuts';
import { createSharedMappingsPlugin } from '../../utils/shared-mappings-plugin';
// import { NextHandleFunction } from 'vite';
import { FederationInfo } from '@softarc/native-federation-runtime';
import { PluginBuild } from 'esbuild';
import { getI18nConfig, translateFederationArtefacts } from '../../utils/i18n';
import { RebuildHubs } from '../../utils/rebuild-events';
import { createSharedMappingsPlugin } from '../../utils/shared-mappings-plugin';
import { updateScriptTags } from '../../utils/updateIndexHtml';
Expand Down Expand Up @@ -135,10 +149,6 @@ export async function* runBuilder(

setLogLevel(options.verbose ? 'verbose' : 'info');

if (!options.outputPath) {
options.outputPath = `dist/${context.target.project}`;
}

const outputPath = options.outputPath;
const outputOptions: Required<
Exclude<ApplicationBuilderOptions['outputPath'], string>
Expand Down Expand Up @@ -283,10 +293,7 @@ export async function* runBuilder(
try {
federationResult = await buildForFederation(config, fedOptions, externals);
} catch (e) {
console.error(e);
if (!watch) {
process.exit(1);
}
process.exit(1);
}

if (activateSsr) {
Expand All @@ -305,7 +312,7 @@ export async function* runBuilder(

options.deleteOutputPath = false;

const appBuilderName = '@angular-devkit/build-angular:application';
const appBuilderName = '@angular/build:application';

const builderRun = runServer
? serveWithVite(
Expand Down
4 changes: 2 additions & 2 deletions libs/native-federation/src/schematics/appbuilder/schematic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ function updateWorkspaceConfig(
}

if (projectConfig.architect.esbuild) {
projectConfig.architect.esbuild.builder =
'@angular-devkit/build-angular:application';
projectConfig.architect.esbuild.builder = '@angular/build:application';

projectConfig.architect.esbuild.options.browser =
projectConfig.architect.esbuild.options.main;
delete projectConfig.architect.esbuild.options.main;
Expand Down
27 changes: 15 additions & 12 deletions libs/native-federation/src/schematics/init/schematic.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import {
chain,
Rule,
Tree,
url,
apply,
chain,
mergeWith,
template,
move,
noop,
Rule,
template,
Tree,
url,
} from '@angular-devkit/schematics';

import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
import { strings } from '@angular-devkit/core';
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
import { MfSchematicSchema } from './schema';

import {
Expand Down Expand Up @@ -234,11 +234,14 @@ function updateWorkspaceConfig(

const originalBuild = projectConfig.architect.build;

if (originalBuild.builder !== '@angular-devkit/build-angular:application') {
if (
originalBuild.builder !== '@angular-devkit/build-angular:application' ||
originalBuild.builder !== '@angular/build:application'
) {
console.log(
'Switching project to the application builder using esbuild ...'
);
originalBuild.builder = '@angular-devkit/build-angular:application';
originalBuild.builder = '@angular/build:application';
delete originalBuild.configurations?.development?.buildOptimizer;
delete originalBuild.configurations?.development?.vendorChunk;
}
Expand Down Expand Up @@ -524,7 +527,7 @@ function makeServerAsync(

const cors = `import { createRequire } from "module";
const require = createRequire(import.meta.url);
const cors = require("cors");
const cors = require("cors");
`;
const mainContent = tree.read(server).toString('utf8');
const updatedContent = (cors + mainContent)
Expand Down Expand Up @@ -553,7 +556,7 @@ console.log('Starting SSR for Shell');
remotesOrManifestUrl: '../browser/federation.manifest.json',
relBundlePath: '../browser/',
});

await import('./bootstrap-server');

})();
Expand All @@ -570,7 +573,7 @@ console.log('Starting SSR for Shell');
remotesOrManifestUrl: ${manifest},
relBundlePath: '../browser/',
});

await import('./bootstrap-server');

})();
Expand All @@ -583,7 +586,7 @@ console.log('Starting SSR for Shell');
await initNodeFederation({
relBundlePath: '../browser/'
});

await import('./bootstrap-server');

})();
Expand Down