Skip to content

fix(nf): Inject importmap-shim to the <head> instead of the end of the <body> #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(nf): Inject importmap-shim to the <head> instead of the end of the <body> #499

merged 1 commit into from
Mar 11, 2024

Conversation

jogelin
Copy link
Contributor

@jogelin jogelin commented Mar 11, 2024

Current Behaviour

In the initFederation function, the importmap-shim script is injected at last in the <body>:

image
  • Usually, it is better to have the import maps earlier because it can be used by other scripts.
  • It should be also specified before the esms-module-shims library (which is located in the polyfills.js)**

**In that use case it is not needed because it is injected afterward and loaded dynamically by esms-module-shims

Expected/Implementation

Inject the import maps in the <head> section instead of the <body>

@manfredsteyer manfredsteyer merged commit 9897a1f into angular-architects:main Mar 11, 2024
@jogelin jogelin mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jogelin @manfredsteyer