Skip to content

Conversation

cy245
Copy link
Contributor

@cy245 cy245 commented Oct 1, 2025

No description provided.

@cy245
Copy link
Contributor Author

cy245 commented Oct 1, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the CredentialManager sample app from the traditional View system (Fragments and XML) to Jetpack Compose. The migration is comprehensive, replacing all UI components, navigation, and adapting the logic to a ViewModel-based architecture. The code is now more modern and follows many Compose best practices.

However, there are a few significant areas for improvement. The most critical is the downgrading of several key AndroidX and Kotlin libraries in build.gradle, which is a regression and should be reverted. Additionally, there are architectural concerns, primarily passing Activity and Context instances into ViewModels, which violates MVVM principles and can lead to memory leaks. I've also left comments on improving navigation logic, state handling, and making Compose Previews more robust.

Overall, this is a great step forward for the sample app. Addressing the feedback will make it an even better example of a modern Android application.

cy245 added 2 commits October 1, 2025 13:33
…ng factories for the view models and instantiating credman through lambda functions passed to the screens.
@cy245 cy245 marked this pull request as ready for review October 7, 2025 20:24
@cy245 cy245 requested a review from niharika2810 as a code owner October 7, 2025 20:24
@cy245 cy245 requested a review from neelanshsahai October 7, 2025 20:24
Copy link
Contributor

@niharika2810 niharika2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chiping, Kindly run Spotless to have copyright, formating and javadocs consitent. WIll review once you are done to focus on other stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants