-
Notifications
You must be signed in to change notification settings - Fork 94
Fixes to Gemini Live Todo #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…w debugging statements.
…es issues with Gemini not responding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vad710, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the Gemini Live Todo sample application by migrating its AI backend to the free googleAI()
service and upgrading to a more recent Gemini model. A significant fix addresses the omission of functionCall.id
in FunctionResponses
, which is vital for the correct operation of function calling. Additionally, new logging statements have been introduced to provide better visibility into the application's audio conversation and function execution flow.
Highlights
- Backend Update: The Gemini model backend has been switched from
vertexAI()
to the freegoogleAI()
backend. - Model Version Upgrade: The application now utilizes a newer Gemini model, specifically
gemini-live-2.5-flash-preview
, replacing the oldergemini-2.0-flash-live-preview-04-09
. - FunctionResponse Fix: An issue where
FunctionResponses
were missing the crucialfunctionCall.id
has been resolved, ensuring proper function call handling. - Improved Logging: Enhanced logging has been added to track the start and stop of audio conversations, as well as the execution of function calls, aiding in debugging and monitoring.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Gemini Live Todo sample to use a newer model and backend, and correctly includes the function call ID in function responses. The changes are functional and address the described issues. I have provided a few suggestions to improve code style by removing excessive blank lines, and a more significant refactoring suggestion for the handleFunctionCall
method to reduce code duplication and improve maintainability.
googleAI()
backend