Add ocamlformat #177
Merged
Add ocamlformat #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2019
Owner
|
@naartjie, thanks a lot! This has been super helpful. I probably wouldn't have gotten around to doing it at this point otherwise, so really appreciate it 🙏 |
Contributor
Author
|
Awesome @andreas. I'm super happy that I could help. Should I take a look at setting up the Travis CI hook next - i.e. fail if the code is not formatted? |
Owner
|
@naartjie that would be amazing 😄 |
Closed
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jul 19, 2022
…d graphql-async (0.14.0) CHANGES: - Support `__typename` on subscriptions (andreas/ocaml-graphql-server#178) - Handle unknown fields for subscriptions (andreas/ocaml-graphql-server#178) - Add ocamlformat (andreas/ocaml-graphql-server#177) - Handle missing variables as null (andreas/ocaml-graphql-server#184) - Show default value in introspection query (andreas/ocaml-graphql-server#194) - Support block strings in the parser (andreas/ocaml-graphql-server#198) - Handle skip/include directives on fragment spreads (andreas/ocaml-graphql-server#200) - Improved handling of recursive arguments and objects (andreas/ocaml-graphql-server#199) - Fix websocket conflict (andreas/ocaml-graphql-server#206) - Update deprecated Fmt functions (andreas/ocaml-graphql-server#206) - Use Yojson `t` types instead of deprecated `json` type (andreas/ocaml-graphql-server#208) - Raise minimum `rresult` version (andreas/ocaml-graphql-server#209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ocamlformat, using theconventionalformat.It only brings the minimum changes necessary to format the project:
After that it is expected that @andreas would commit those changes as the main author. After that we would enforce the formatting rules on travisCI (as per @anmonteiro's suggestion) to ensure that any new code merged follows the formatting rules.