[backport dashing] support flake8 3.8 #252
Conversation
Signed-off-by: Dirk Thomas <[email protected]>
|
@mjcarroll perhaps? Users who build Dashing from source via https://index.ros.org/doc/ros2/Installation/Dashing/Linux-Development-Setup/ will have all flake8 tests be broken without it Problem is that the pip install gets them flake8 3.8 |
dirk-thomas
changed the title
|
Backport of #242. (@emersonknapp references in the ticker title don't cross reference.) |
dirk-thomas
changed the title
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM, but I'm going to defer to @nuclearsandwich on this one (for Dashing).
This gives more control over which linters are run. For example, we don't need to depend on Python linters for many packages. This commit also worksaround an upstream issue with CI, where ament_cmake_flake8 is currently failing with a Dashing installation if flake8 is installed from pip. See ament/ament_lint#252 for a fix upstream. Signed-off-by: Jacob Perron <[email protected]>
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <[email protected]>
|
@nuclearsandwich friendly ping :) |
Thanks for keeping me in the loop. For the future. I don't need to gatekeep Dashing backport PRs unless there's a deadlock or some sort of judgement call about breakages that needs to be made. It is important to make sure that backport PRs make it onto the patch release board (which this one is, even thought it's hard to tell because it's outside the ROS 2 org) so we make sure that backports also get releases but I don't feel the need to approve each and every one. |
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <[email protected]>
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <[email protected]>
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <[email protected]>
6 participants
Backport of #242
Signed-off-by: Dirk Thomas [email protected]