Skip to content

Null invalid PostalCode #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Null invalid PostalCode #1467

merged 6 commits into from
Jul 8, 2022

Conversation

jeff-hernandez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1467 (6d356e0) into main (16f52ea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          95       95           
  Lines       10620    10654   +34     
=======================================
+ Hits        10481    10515   +34     
  Misses        139      139           
Impacted Files Coverage Δ
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/logical_types/test_logical_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f52ea...6d356e0. Read the comment docs.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review July 7, 2022 15:38
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sold to me! I'm a little concerned about Panda's inconsistency in null type handling and it feels like we're constantly making small changes to support, handle, assign, compare, and convert pd.NA. Its ambiguity is something we have to keep an eye on.

@jeff-hernandez jeff-hernandez merged commit b91455f into main Jul 8, 2022
@jeff-hernandez jeff-hernandez deleted the null-invalid-postal-code branch July 8, 2022 16:50
@ParthivNaresh ParthivNaresh mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants