Fix unmarshaller prefetch align #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using the slow MOD (%) operator. Use bitvise AND (&) instead. Signed-off-by: Robin Jarry <[email protected]>
When the message header is not a multiple of 8 bytes long, the alignment bytes will not be prefetched and an additional read() system call will be made when reading the end of the body. Add the padding bytes to the prefetch length. Fixes: 7efeef4 ("unmarshaller: reduce number of read system calls") Signed-off-by: Robin Jarry <[email protected]>
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the message header is not a multiple of 8 bytes long, there will be an additional read performed when reading the body since there is an alignment after reading the header. I forgot to take this into account in #62.
I also added a small optimization in padding computing since I needed a separate function to get header padding.