Skip to content

Conversation

RainzDev
Copy link
Contributor

@RainzDev RainzDev commented May 1, 2025

Description

The reason why I believe this should be removed is because there could be other reasons to why users would react to their own message with a star

Guidelines

  • My code follows the style guidelines of this project (formatted with Ruff)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation if needed

  • My changes generate no new warnings

  • I have tested this change

  • Any dependent changes have been merged and published in downstream modules

  • I have added all appropriate labels to this PR

  • I have followed all of these guidelines.

Summary by Sourcery

Enhancements:

  • Modify starboard reaction handling to allow users to keep their star reaction on their own messages

…wn message

The reason why I believe this should be removed is because there could be other reasons to why users would react to their own message with a star
Copy link

trunk-io bot commented May 1, 2025

✨ This comment will be updated with CI stats as CI jobs run ✨
settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

sourcery-ai bot commented May 1, 2025

Reviewer's Guide

This pull request removes the automatic deletion of a user's reaction if they react to their own message within the starboard feature by deleting the relevant code lines in the reaction handler.

File-Level Changes

Change Details Files
Removed automatic deletion of self-reactions for starboard
  • Deleted the message.remove_reaction call targeting the message author.
  • Removed the associated contextlib.suppress block.
tux/cogs/services/starboard.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RainzDev - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@electron271
Copy link
Member

should be decided when running $starboard setup not hard coded, might be a good idea to wait for #843 though

Copy link
Member

@electron271 electron271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous comment

@electron271 electron271 marked this pull request as draft May 10, 2025 16:07
@RainzDev
Copy link
Contributor Author

should be decided when running $starboard setup not hard coded, might be a good idea to wait for #843 though

Yeah, I figured I'd have to wait for that to finish up. And yea, I agree configuration should be added.

@anemoijereja-eden anemoijereja-eden added the status: waiting for db migration changes require extensive use of the database system label Jun 23, 2025
@anemoijereja-eden anemoijereja-eden self-assigned this Jun 23, 2025
@electron271 electron271 changed the title removed the ability to delete the user reaction if reacted to their o… fix: make whether starboard self-reacting is allowed configurable Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for db migration changes require extensive use of the database system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants