Fix Cookie.GetInt/SetInt buffer size #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation does not account for negative sign or null term
psychonic
approved these changes
Apr 21, 2023
peace-maker
approved these changes
Apr 21, 2023
Member
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
That microoptimization seems unnecessarily strict on the buffer size anyway. We could just do some power of 2 to be nice to values with leading whitespace in GetInt. But this is ok too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not account for large negative numbers (
-2147483648)