Update TranslateService.php #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(TranslateService): enhance readability, flexibility & error handling - Renamed variables to more descriptive names (e.g., `translate_from` ➝ `sourceLanguage`) - Added caching mechanism for repeated translations - Introduced dry-run mode to allow testing without saving - Added option to disable parameter preservation - Improved error messages for better debugging - Added strict type hints for better static analysis - Split large methods into smaller single-responsibility methods - Validated source and target languages for correctness Thank you so much for your thoughtful feedback and contributions — you've made this service cleaner, smarter, and easier to maintain. 🙏
|
Hey @itashia Thanks for the PR. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(TranslateService): enhance readability, flexibility & error handling
translate_from➝sourceLanguage)Thank you so much for your thoughtful feedback and contributions — you've made this service cleaner, smarter, and easier to maintain. 🙏