Skip to content

Conversation

@dhayab
Copy link
Member

@dhayab dhayab commented Jun 29, 2023

Summary

bundlesize relies on an old version of brotli-size, which in turn uses iltorb, un unmaintained package that, when no prebuilt release exists (for ARM architectures in Apple Mx processors for example), tries to build itself from source which in most cases result in failure (it requires python as well as g++).

To make it easier for people to install the repository, a simple workaround is to force bundlesize to use another version of brotli-size. Fortunately, it works as well (yarn bundlesize reports sizes successfully).

Result

Installing dependencies for this repository is easier and does not fail in as many environments as before.

@dhayab dhayab requested review from a team, aymeric-giraudet and sarahdayan and removed request for a team June 29, 2023 14:15
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5854f3a:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv
Copy link
Contributor

Haroenv commented Jun 30, 2023

could even be aliased to a noop as it's not used for us

@dhayab
Copy link
Member Author

dhayab commented Jun 30, 2023

could even be aliased to a noop as it's not used for us

We could as well. In this case we already have a dependency on brotli-size from rollup, so it will retrieve the package either way.

@dhayab dhayab merged commit 739b49e into next Jun 30, 2023
@dhayab dhayab deleted the chore/yarn-resolution-brotli-size branch June 30, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants