Return the request object when calling index! rather than nil #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @such, thanks for your PR! May I ask you to add some tests along with your changes? Have a good day! |
Fix Batch index
|
Thanks for your PR, sorry that we have taken a long time to respond. In the mean time the branches have gotten quite out of date, so we couldn't just merge as-is. However I do understand why you'd want to retrieve the resulting tasks. To be consistent, we'd want to return that with all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
This gives access to the Algolia request (including the taskID) when using the Rails API (eg object.index!).
What problem is this fixing?
This is useful when we want to check the status of a task after indexing an object and when the synchronous API is not suitable to our needs.