Skip to content

Conversation

olethanh
Copy link
Collaborator

Do not run export log if cancelled or not setup
Attempt to always do the proper clean up

Print more debug information in case the droplet ipv4 cannot be parsed

Explain what problem this PR is resolving

Related ClickUp, GitHub or Jira tickets : ALEPH-XXX

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Do not run export log if cancelled or not setup
Attempt to always do the proper clean up

Print more debug information in case the droplet ipv4 cannot be parsed
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (73013a2) to head (ac45817).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          77       77           
  Lines        6854     6854           
  Branches      576      576           
=======================================
  Hits         4341     4341           
  Misses       2325     2325           
  Partials      188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh
Copy link
Collaborator Author

Merged as part of #787

@olethanh olethanh closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant