Skip to content

Fix start error in load_persistent_executions #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix start error in load_persistent_executions #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01139fd
Fix start error in load_persistent_executions
olethanh Feb 20, 2025
367cddc
Fix packaging issue caused by sevctl
olethanh Feb 20, 2025
2840128
Merge branch 'main' into ol-fix-start-on-load_persistent_executions
olethanh Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ download-ipfs-kubo: target-dir build-dir
curl -fsSL https://github.com/ipfs/kubo/releases/download/v0.23.0/kubo_v0.23.0_linux-amd64.tar.gz | tar -xz --directory ./target/kubo

target/bin/sevctl:
cargo install --git https://github.com/virtee/sevctl.git --rev v0.6.0 --target x86_64-unknown-linux-gnu --root ./target
cargo install --locked --git https://github.com/virtee/sevctl.git --rev v0.6.0 --target x86_64-unknown-linux-gnu --root ./target
./target/bin/sevctl -V

version:
Expand Down
2 changes: 1 addition & 1 deletion src/aleph/vm/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
if execution.is_running:
# TODO: Improve the way that we re-create running execution
# Load existing GPUs assigned to VMs
execution.gpus = parse_raw_as(List[HostGPU], saved_execution.gpus)
execution.gpus = parse_raw_as(List[HostGPU], saved_execution.gpus) if saved_execution.gpus else []

Check warning on line 252 in src/aleph/vm/pool.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/pool.py#L252 

Added line #L252 was not covered by tests
# Load and instantiate the rest of resources and already assigned GPUs
await execution.prepare()
if self.network:
Expand Down