[vscode_projects:1.0] Release plugin

[Sharsie]

I have done a rewrite of my previous implementation into the new API, I know it is a more complex plugin than the other options, but my long standing goal is to support the Project Manager extension without relying too much on the recently opened files.

Additionally this implementation provides optional configuration to open VS Code through terminal for advanced use, e.g. where users need to load an environment prior to opening VS Code for example.
My usecase is direnv + nix shell, I have separate environments in each of my projects and entering those directories in shell loads all necessary dependencies and binaries needed for that specific project. This also requires VS Code to be opened from that directory in order to have the correct environment inside the IDE.

So here it is, if you find it useful, I'm happy to support it going forward, if not, I'll just support myself :)

[ManuelSchneid3r]

Hi, quite a bunch of lines but i guess people will love it. Just a note: py api v2.3 is out. theres a matcher which does imlicit normalization and such.

[Sharsie]

I updated the plugin to use the latest version and the matcher, but noticed the iconUrls defined on the plugin itself stopped working with 0.24.1 (this is not just this plugin, but all of them). Icons on the item results work fine.

Are there any notes on how to migrate these? I noticed in the c++ version of the Timer plugin, that this is provided through a .qrc file

[ManuelSchneid3r]

Are there any notes on how to migrate these? I noticed in the c++ version of the Timer plugin, that this is provided through a .qrc file

thats the c++ way to ship a plugin as a single module. icon urls should actually work as expected. they work on my system. but yes I changed the icon provider api and maybe introduced a bug. i have to check it on a linux box.

[ManuelSchneid3r]

@Sharsie you can drop the string normalization. the matcher does this already unless configured otherwise. see this

[Sharsie]

Oh, very cool, dropped

[ManuelSchneid3r]

import unicodedata is still there

[Sharsie]

damn, that's what happens when you do a quick edit in terminal :) Thanks for catching it, fixed

[Silureth]

@Sharsie thanks for returning! Been using your extension for a long time with early versions of Albert. Just fixing/clobbering it enough to work with the current versions (have my own Frankenstein repo) but since I'm not too comfortable in python never tried to added it to the official plugins.
I'll try it out later and report if there is any problem.

[ManuelSchneid3r]

this has been open way to long. sad that nobody wants to spend some minutes to review plugins. i skimmed over it. lgtm, although I did no review in detail really. just merged it now. maybe some more reviews will follow.

[ManuelSchneid3r]

thank you and thank you for your patience.

[Sharsie]

Wow, merged after 4 years. Yea I get the frustration, maybe it's just too niche.

I'll support it to the best of my ability, will probably make some updates to support vscode forks too, since nowdays I keep another version locally.

@Silureth I've been trying to keep it up to date for years now, but feel free to ping me if something breaks.

[ManuelSchneid3r]

I am sorry but I don't use it. As such I am not really a suitable reviewer. Generally I don't merge unreviewed code and don't review code I can't understand.

I just wonder if it is not that niche why not a single reviewer took the effort.

[Silureth]

Ok, I've been testing it for a while and two things i found:

1st
The trigger is in the input action text, my trigger is "vc" and it shows as vc 'search query' vc vc:

it can be fixed easily by modifying on line 362
inputActionText=f"{query.trigger}{project.displayName}",
->
inputActionText=f"{project.displayName}",
this is problematic because tabbing it completes it with "vc vc" in the front of the selected item which won't work that way

2nd the recents wont show up, it's not bothering me because I would have disabled it from the start

1st i could fix with a pull if it's all right.

[Sharsie]

1st - Oh dear, I fixed that in my other local plugin and forgot to update this one. If you don't mind, send a PR please.

2nd - Thanks, I'll take a look, there are occasional changes and for one of the vscode forks, this actually stopped working recently and recents can only be queried through sqlite instead of parsing the config file. I'll check if that's the case and update it

[Sharsie]

@Silureth Got some time now, I'll send a PR

#224