parameterise big benchmarks by property #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see the scripts that produce these. The tests are still changing since many of them don't currently work properly under run_benchmark, they'll need to be regenerated. |
We create 5 versions for each CSS animation and transition benchmark:- - compositor-transform = transform animation on compositor thread - mainthread-transform = transform animation on main thread - opacity = opacity animation on compositor thread - px-height = height animation on main thread - specific-color = color animation on main thread For web animations, we create the above 5 versions and 3 more:- - em-height = height animation responsive to font size - inherit-height = height animation responsive to parent height - current-color = color animation responsive to parent color run-big-benchmarks.py is updated to use the generated versions. A small number of benchmarks fail, sometimes because we have too many elements. For example, in one run the following failed:- - web-animations-staggered-chaining-compositor-transform.html - css-animations-staggered-chaining-by-inserting-style-element-px-height.html - css-transitions-simultaneous-by-inserting-style-element-specific-color.html - css-transitions-staggered-chaining-by-updating-class-px-height.html - css-animations-staggered-chaining-by-inserting-style-element-specific-color.html - css-animations-staggered-chaining-by-inserting-style-element-mainthread-transform.html - css-transitions-simultaneous-by-inserting-style-element-px-height.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.