-
Notifications
You must be signed in to change notification settings - Fork 31
chore: update source-declarative-manifest base image to use python 3.13 #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update source-declarative-manifest base image to use python 3.13 #805
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@dbgold17/python-3.13-source-declarative-manifest#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch dbgold17/python-3.13-source-declarative-manifestHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the source-declarative-manifest connector to use Python 3.13 by changing the base Docker image from the stable 4.0.2 release to a development test image (dev-test-python-3.13).
Key changes:
- Updated Docker base image from
python-connector-base:4.0.2topython-connector-base:dev-test-python-3.13
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThe Dockerfile updates its base image reference from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Would you like me to also run a quick checklist for other files that commonly require Python-version bumps (CI configs, tox/pyproject, Docker manifests) to ensure consistency, wdyt? Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
PyTest Results (Fast)3 813 tests +11 3 801 ✅ +11 6m 27s ⏱️ -7s Results for commit 85cc064. ± Comparison against base commit 6b747fe. This pull request removes 1 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
What
Build and Release a new Source Declarative Manifest Base image using Python 3.13
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/14879
Depends on airbytehq/airbyte#68190
Summary by CodeRabbit