Skip to content

Conversation

@dbgold17
Copy link
Contributor

@dbgold17 dbgold17 commented Oct 20, 2025

What

Build and Release a new Source Declarative Manifest Base image using Python 3.13
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/14879
Depends on airbytehq/airbyte#68190

Summary by CodeRabbit

  • Chores
    • Updated base Docker image to version 4.1.0
    • Updated Python runtime environment to version 3.13

@github-actions
Copy link

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@dbgold17/python-3.13-source-declarative-manifest#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch dbgold17/python-3.13-source-declarative-manifest

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@dbgold17 dbgold17 marked this pull request as ready for review October 20, 2025 22:47
Copilot AI review requested due to automatic review settings October 20, 2025 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the source-declarative-manifest connector to use Python 3.13 by changing the base Docker image from the stable 4.0.2 release to a development test image (dev-test-python-3.13).

Key changes:

  • Updated Docker base image from python-connector-base:4.0.2 to python-connector-base:dev-test-python-3.13

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

The Dockerfile updates its base image reference from docker.io/airbyte/python-connector-base:4.0.2@sha256:... to docker.io/airbyte/python-connector-base:4.1.0@sha256:... and changes two COPY source paths to use Python 3.13 site-packages (/usr/local/lib/python3.13/...) instead of Python 3.11. No other build steps or entrypoint changes reported.

Changes

Cohort / File(s) Summary
Dockerfile (base image & site-packages paths)
Dockerfile
Bumped base image from airbyte/python-connector-base:4.0.2@sha256:... to airbyte/python-connector-base:4.1.0@sha256:...; updated COPY source paths from /usr/local/lib/python3.11/... to /usr/local/lib/python3.13/... for referenced files (site-packages copies).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • brianjlai

Would you like me to also run a quick checklist for other files that commonly require Python-version bumps (CI configs, tox/pyproject, Docker manifests) to ensure consistency, wdyt?

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: update source-declarative-manifest base image to use python 3.13" clearly and directly summarizes the main objective of the pull request. It specifically identifies the component (source-declarative-manifest), the action (update base image), and the primary change (Python 3.13 upgrade), which aligns perfectly with the PR objectives and the actual code changes in the Dockerfile. The title is concise, uses clear language without vague terms, and provides sufficient context for a teammate reviewing the history to immediately understand the changeset's purpose.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dbgold17/python-3.13-source-declarative-manifest

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

PyTest Results (Fast)

3 813 tests  +11   3 801 ✅ +11   6m 27s ⏱️ -7s
    1 suites ± 0      12 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 85cc064. ± Comparison against base commit 6b747fe.

This pull request removes 1 and adds 12 tests. Note that renamed tests count towards both.
unit_tests.sources.declarative.requesters.query_properties.test_query_properties ‑ test_get_request_property_chunks_static_list_with_chunking
unit_tests.sources.declarative.parsers.test_model_to_component_factory ‑ test_create_component_with_configured_catalog
unit_tests.sources.declarative.requesters.query_properties.property_selector.test_json_schema_property_selector ‑ test_select_properties[configured_stream_is_none]
unit_tests.sources.declarative.requesters.query_properties.property_selector.test_json_schema_property_selector ‑ test_select_properties[configured_stream_no_properties_key_in_json_schema]
unit_tests.sources.declarative.requesters.query_properties.property_selector.test_json_schema_property_selector ‑ test_select_properties[test_select_properties_with_transformations]
unit_tests.sources.declarative.requesters.query_properties.test_property_chunking ‑ test_get_request_property_chunks_empty_configured_properties
unit_tests.sources.declarative.requesters.query_properties.test_property_chunking ‑ test_get_request_property_chunks_none_configured_properties
unit_tests.sources.declarative.requesters.query_properties.test_query_properties ‑ test_get_request_no_property_chunking_always_include_properties
unit_tests.sources.declarative.requesters.query_properties.test_query_properties ‑ test_get_request_no_property_chunking_selected_properties_always_include_properties
unit_tests.sources.declarative.requesters.query_properties.test_query_properties ‑ test_get_request_property_chunks_static_list_with_chunking_property_selection
unit_tests.sources.declarative.requesters.query_properties.test_query_properties ‑ test_get_request_property_chunks_with_configured_catalog_dynamic_endpoint
…

♻️ This comment has been updated with latest results.

@dbgold17 dbgold17 requested a review from aaronsteers October 23, 2025 20:56
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbgold17 dbgold17 changed the title source-declarative-manifest on python 3.13 Update source-declarative-manifest base image to use python 3.13 Oct 23, 2025
@dbgold17 dbgold17 changed the title Update source-declarative-manifest base image to use python 3.13 chore: update source-declarative-manifest base image to use python 3.13 Oct 23, 2025
@dbgold17 dbgold17 merged commit 6126d6e into main Oct 23, 2025
21 of 24 checks passed
@dbgold17 dbgold17 deleted the dbgold17/python-3.13-source-declarative-manifest branch October 23, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants