Skip to content

feat(low-code): improve logging on async retriever errors #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2025
Merged

feat(low-code): improve logging on async retriever errors #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26629fe
Improve logging
maxi297 Jan 31, 2025
c3fac9c
Improve logging
maxi297 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airbyte_cdk/sources/declarative/async_job/job_orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,10 @@ def create_and_get_completed_partitions(self) -> Iterable[AsyncPartition]:
yield from self._process_running_partitions_and_yield_completed_ones()
self._wait_on_status_update()
except Exception as exception:
LOGGER.warning(
f"Caught exception that stops the processing of the jobs: {exception}. Traceback: {traceback.format_exc()}"
)
if self._is_breaking_exception(exception):
LOGGER.warning(
f"Caught exception that stops the processing of the jobs: {exception}"
)
self._abort_all_running_jobs()
raise exception

Expand Down
Loading