missing function expression name : naming / semantics

[gkatsanos]

Assuming a function expression that toggles the visibility of <tr>s depending on some criteria,

const filterRows = function () {
...
}

39:23 warning Missing function expression name func-names

I'm running into difficulty finding a name for that function expression as the rule suggests. More often it would be pure duplication of the variable in which the function is saved.

Any ideas on how to properly redact a meaningful name that isn't a duplicate of the variable name?

[ljharb]

What does this function do, conceptually?

[gkatsanos]

@ljharb well I have several. I'll paste them so it's a bit clearer. (sorry for the long paste in advance)

const filterRow = function (tableData, activeFilters) {
  const filtersEnabled = Object.keys(activeFilters).filter(element => activeFilters[element].length !== 0);
  return tableData.filter(row => filtersEnabled.every(k => activeFilters[k].indexOf(row[k]) !== -1));
};

const updateDisplay = function () {
  const visibleRows = filterRow(data, filters);
  $tableRows.removeClass('hidden');
  $tableRows.filter((index, row) => !visibleRows.some(job => job.id === Number(row.dataset.id))).addClass('hidden');
};

const toggleFilterMode = function () {
  $(this).toggleClass('on');
  $('.selection').toggleClass('hidden');
  $('.dropdown-toggle').toggleClass('disabled');
  prepareFilters();
  updateDisplay();
  $dropdownLinks.removeClass('active');
};

I just cant seem to find a way to use the function name without duplicating (so tempted to add an exception for that rule in my eslintrc config..)

[ljharb]

const filterRow = function filterAllEnabledRows? Generally I make the var name be a bit more concise and generic, and the function name verbose and specific.

[gkatsanos]

@ljharb semantically that doesn't add any value though right? you could very well use a specific and verbose var name..

[ljharb]

The value I see is that in stack traces, you'll see a very specific function name, which you can grep for across your whole codebase and find in only one location, whereas the generic name might appear in a handful of files.