[Fix] Register module binding #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ljharb
approved these changes
Dec 28, 2019
|
woohoo! Thanks guys :) |
|
@ljharb cool if we publish this hotfix to npm? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests registers the React import added by this plugin. This is necessary as Babel does not automatically detect new bindings.
As a result, two or more Babel plugins can implement this behavior and all rely on
path.scope.hasBinding('React')to prevent duplication.I eliminated the destructuring assignment as
unshiftContainerrelies onthis(path).Also added a test that ensures the binding is present.
Fixes #50