Skip to content

Support passing an alias object to fix issues with babel module resolver #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support passing an alias object to fix issues with babel module resolver #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { extname, dirname, parse as parseFilename } from 'path';
import { readFileSync } from 'fs';
import { extname, dirname, parse as parseFilename, resolve as resolvePath } from 'path';
import { readFileSync, existsSync } from 'fs';
import { parse } from '@babel/parser';
import { declare } from '@babel/helper-plugin-utils';
import resolve from 'resolve';
Expand Down Expand Up @@ -48,7 +48,7 @@ export default declare(({
if (typeof importPath !== 'string') {
throw new TypeError('`applyPlugin` `importPath` must be a string');
}
const { ignorePattern, caseSensitive, filename: providedFilename } = state.opts;
const { ignorePattern, caseSensitive, filename: providedFilename, root, alias } = state.opts;
const { file, filename } = state;
if (ignorePattern) {
// Only set the ignoreRegex once:
Expand All @@ -61,14 +61,40 @@ export default declare(({
// This plugin only applies for SVGs:
if (extname(importPath) === '.svg') {
const iconPath = filename || providedFilename;
const svgPath = resolve.sync(importPath, { basedir: dirname(iconPath) });
if (caseSensitive && !fileExistsWithCaseSync(svgPath)) {
throw new Error(`File path didn't match case of file on disk: ${svgPath}`);
const aliasPart = importPath.split('/')[0];
const aliasMatch = alias[aliasPart];
const svgPaths = [];
let chosenPath;

if (aliasMatch) {
const resolveRoot = resolvePath(process.cwd(), root || './');
const aliasMatches = typeof aliasMatch === 'string' ? [aliasMatch] : aliasMatch;

aliasMatches.forEach((match) => {
const aliasedPath = resolvePath(resolveRoot, match);
svgPaths.push(resolvePath(aliasedPath, importPath.replace(`${aliasPart}/`, '')));
});
} else {
svgPaths.push(resolve.sync(importPath, { basedir: dirname(iconPath) }));
}
if (!svgPath) {

for (let i = 0; i < svgPaths.length; i += 1) {
const svgPath = svgPaths[i];
if (caseSensitive && !fileExistsWithCaseSync(svgPath)) {
throw new Error(`File path didn't match case of file on disk: ${svgPath}`);
}

if (svgPath && existsSync(svgPath)) {
chosenPath = svgPath;
break;
}
}

if (!chosenPath) {
throw new Error(`File path does not exist: ${importPath}`);
}
const rawSource = readFileSync(svgPath, 'utf8');

const rawSource = readFileSync(chosenPath, 'utf8');
const optimizedSource = state.opts.svgo === false
? rawSource
: optimize(rawSource, state.opts.svgo);
Expand Down