Skip to content

Conversation

FlatBallFlyer
Copy link
Contributor

@FlatBallFlyer FlatBallFlyer commented Nov 8, 2024

Re-organized the docker-compose, added kafka-connect and related services, improved service names for initilization containers, added new elasticsearch kibana and initialization containers. Also closes #31

Meaningful changes to the ARCHITECTURE.md, and docker-compose.yaml file.
Lot's of spelling corrections in various markdown files.

NOTE: This update will break many default mongo cconnection strirng values. There are open issues on those repo's awaiting this merge.

@michquinn
Copy link
Contributor

s/initilize/initialize/g

Copy link
Contributor

@michquinn michquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Infrastructure diagram in ARCHITECTURE.md may need to be updated as well (AWS OpenSearch?). Other than that, looks good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lazy, and it helps vscode users

kafka-connect:
image: ghcr.io/agile-learning-institute/mentorhub-kafka-connect:latest
ports:
- "9093:8083"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting a comment above this line for confused visitors

Copy link
Contributor Author

@FlatBallFlyer FlatBallFlyer Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this

  ##################################
  # Kafka Connector (Custom connector with Mongo and Elastic plugins)
      image: ghcr.io/agile-learning-institute/mentorhub-kafka-connect:latest

and the image name lists the repo where the README explains it.

--> SearchService[(ElasticSearch)]
end
Lambda <--> BUS
SearchService --> BUS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the arrow pointing the right way here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the other way around, I couldn't get to work that way. I went ahead and made it a two sided arrow like we had it before it's still wrong, but it doesn't look as wrong.

michquinn

This comment was marked as duplicate.

Comment on lines 52 to 55
ulimits:
memlock:
soft: -1
hard: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI to future readers: I couldn't even get the container to run until this was removed. YMMV

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding this!

@FlatBallFlyer FlatBallFlyer merged commit 6cd1153 into main Dec 7, 2024
@FlatBallFlyer FlatBallFlyer deleted the kafka-cdc branch December 7, 2024 22:40
michquinn added a commit that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Initial Search Data Store
2 participants