-
Notifications
You must be signed in to change notification settings - Fork 3
Elastic Updates #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Updates #104
Conversation
s/initilize/initialize/g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Infrastructure diagram in ARCHITECTURE.md may need to be updated as well (AWS OpenSearch?). Other than that, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lazy, and it helps vscode users
kafka-connect: | ||
image: ghcr.io/agile-learning-institute/mentorhub-kafka-connect:latest | ||
ports: | ||
- "9093:8083" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider putting a comment above this line for confused visitors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is this
##################################
# Kafka Connector (Custom connector with Mongo and Elastic plugins)
image: ghcr.io/agile-learning-institute/mentorhub-kafka-connect:latest
and the image name lists the repo where the README explains it.
specifications/ARCHITECTURE.md
Outdated
--> SearchService[(ElasticSearch)] | ||
end | ||
Lambda <--> BUS | ||
SearchService --> BUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the arrow pointing the right way here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the other way around, I couldn't get to work that way. I went ahead and made it a two sided arrow like we had it before it's still wrong, but it doesn't look as wrong.
ulimits: | ||
memlock: | ||
soft: -1 | ||
hard: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI to future readers: I couldn't even get the container to run until this was removed. YMMV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for finding this!
Re-organized the docker-compose, added kafka-connect and related services, improved service names for initilization containers, added new elasticsearch kibana and initialization containers. Also closes #31
Meaningful changes to the ARCHITECTURE.md, and docker-compose.yaml file.
Lot's of spelling corrections in various markdown files.
NOTE: This update will break many default mongo cconnection strirng values. There are open issues on those repo's awaiting this merge.