Skip to content

Indexed fields as spans #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2020
Merged

Indexed fields as spans #780

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b34653f
Added a rough outline of my C# value type encoder/decoder.
gatesy Aug 22, 2019
0ec5234
Revert "Added a rough outline of my C# value type encoder/decoder."
gatesy May 13, 2020
0e36e05
Merge remote-tracking branch 'upstream/master'
gatesy May 13, 2020
989a978
Expose an array property as a span
gatesy May 13, 2020
c989139
Get the Length property right
gatesy May 13, 2020
a7b37da
Get the type right
gatesy May 13, 2020
7881a8a
Add field-as-span method
gatesy May 14, 2020
fc08ce3
Set the type correctly
gatesy May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,27 @@ private CharSequence generateArrayProperty(
generateDocumentation(indent, fieldToken),
propName, typeName, fieldLength, typePrefix, offset, typeSize, byteOrderStr));

// Expose the array as a ReadOnlySpan
sb.append(String.format("\n" +
"%1$s" +
indent + "public ReadOnlySpan<%2$s> %3$s\n" +
indent + "{\n" +
indent + INDENT + "get => _buffer.AsReadOnlySpan<%2$s>(_offset + %4$s, %3$sLength);\n" +
indent + INDENT + "set => value.CopyTo(_buffer.AsSpan<%2$s>(_offset + %4$s, %3$sLength));\n" +
indent + "}\n",
generateDocumentation(indent, fieldToken),
typeName, propName, offset));

// Expose the array as a Span
sb.append(String.format("\n" +
"%1$s" +
indent + "public Span<%2$s> %3$sAsSpan()\n" +
indent + "{\n" +
indent + INDENT + "return _buffer.AsSpan<%2$s>(_offset + %4$s, %3$sLength);\n" +
indent + "}\n",
generateDocumentation(indent, fieldToken),
typeName, propName, offset));

if (typeToken.encoding().primitiveType() == PrimitiveType.CHAR)
{
generateCharacterEncodingMethod(sb, propertyName, typeToken.encoding().characterEncoding(), indent);
Expand Down