In the encodeWith method of the dto object, the Java code generator did not handle all the keyword replacements properly.

[shenzlx]

schema.xml

  <sbe:message id="100" name="OnRtnBulletin" >
        <field id="1" name="ExchangeID" type="TThostFtdcExchangeIDType" />
        <field id="2" name="TradingDay" type="TThostFtdcDateType"  />
        <field id="3" name="BulletinID" type="TThostFtdcBulletinIDType" />
        <field id="4" name="SequenceNo" type="TThostFtdcSequenceNoType" />
        <field id="5" name="NewsType" type="TThostFtdcNewsTypeType"  />
        <field id="6" name="NewsUrgency" type="TThostFtdcNewsUrgencyType" />
        <field id="7" name="SendTime" type="TThostFtdcTimeType"  />
        <field id="8" name="Abstract" type="TThostFtdcAbstractType" />
        <field id="9" name="ComeFrom" type="TThostFtdcComeFromType" />
        <field id="10" name="Content" type="TThostFtdcContentType"  />
        <field id="11" name="URLLink" type="TThostFtdcURLLinkType"  />
        <field id="12" name="MarketID" type="TThostFtdcMarketIDType" />
    </sbe:message>

generated code section：

    public static void encodeWith(OnRtnBulletinEncoder encoder, OnRtnBulletinDto dto)
    {
        encoder.exchangeID(dto.exchangeID());
        encoder.tradingDay(dto.tradingDay());
        encoder.bulletinID(dto.bulletinID());
        encoder.sequenceNo(dto.sequenceNo());
        encoder.newsType(dto.newsType());
        encoder.newsUrgency(dto.newsUrgency());
        encoder.sendTime(dto.sendTime());
        encoder.**abstract**(dto.abstractSBE());
        encoder.comeFrom(dto.comeFrom());
        encoder.content(dto.content());
        encoder.uRLLink(dto.uRLLink());
        encoder.marketID(dto.marketID());
    }

[vyazelenko]

@shenzlx Java DTO generator does handle special names correctly. See 552b447.

The trick is to set -Dsbe.keyword.append.token=somevalue to ensure that suffix will be appended to each keyword value.

[shenzlx]

@shenzlx Java DTO generator does handle special names correctly. See 552b447.

The trick is to set -Dsbe.keyword.append.token=somevalue to ensure that suffix will be appended to each keyword value.

According to the documentation, I set sbe.keyword.append.token = SBE.

<plugin>
                        <groupId>org.codehaus.mojo</groupId>
                        <artifactId>exec-maven-plugin</artifactId>
                        <version>3.1.0</version>
                        <executions>
                            <execution>
                                <phase>generate-sources</phase>
                                <goals>
                                    <goal>java</goal>
                                </goals>
                            </execution>
                        </executions>
                        <configuration>
                            <includeProjectDependencies>false</includeProjectDependencies>
                            <includePluginDependencies>true</includePluginDependencies>
                            <mainClass>uk.co.real_logic.sbe.SbeTool</mainClass>
                            <systemProperties>
                                <systemProperty>
                                    <key>sbe.output.dir</key>
                                    <value>${project.build.directory}/generated-sources/java</value>
                                </systemProperty>
                                <systemProperty>
                                    <key>sbe.keyword.append.token</key>
                                    <value>SBE</value>
                                </systemProperty>
                            </systemProperties>
                            <arguments>
                                <argument>${project.build.resources[0].directory}/schema/ctp.xml</argument>
                            </arguments>
                            <workingDirectory>${project.build.directory}/generated-sources/java</workingDirectory>
                        </configuration>
                        <dependencies>
                            <dependency>
                                <groupId>uk.co.real-logic</groupId>
                                <artifactId>sbe-tool</artifactId>
                                <version>1.35.6</version>
                            </dependency>
                        </dependencies>
                    </plugin>

Then three classes were generated: OnRtnBulletinEncoder, OnRtnBulletinDecoder, and OnRtnBulletinDto.

My complaint is that the implementation of the encodeWith static method in the OnRtnBulletinDto class does not properly handle the call to the OnRtnBulletinEncoder method: encoder.abstract(dto.abstractSBE());, even though OnRtnBulletinEncoder is declared as abstractSBE (which is what I expected).

The actual behavior doesn't seem to match line 1072 of code .

[vyazelenko]

@shenzlx You need to enable DTO generation when you are running SbeTool, i.e. add:

    <systemProperty>
        <key>sbe.java.generate.dtos</key>
        <value>true</value>
    </systemProperty>

Without -Dsbe.java.generate.dtos=true the tool will only generate encoders and decoders but not DTOs.

[shenzlx]

@shenzlx You need to enable DTO generation when you are running SbeTool, i.e. add:

<systemProperty>
    <key>sbe.java.generate.dtos</key>
    <value>true</value>
</systemProperty>

Without -Dsbe.java.generate.dtos=true the tool will only generate encoders and decoders but not DTOs.

Thank you for your answer. My project isn't standalone, so the configuration you mentioned is actually already included elsewhere. The DTO object has actually been generated, but...

encoder.abstract(dto.abstractSBE());

abstract in the above band should be abstractSBE!!!

[vyazelenko]

@shenzlx Please provide the full standalone reproducer for the problem you are seeing.

As I previously mentioned we have tests that verify the correct behavior, see:

simple-binary-encoding/sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/DtoTest.java

Lines 77 to 102 in cb4eb1f

	void dtoWithKeywords()
	{
	final KeywordsDto dto = new KeywordsDto();
	dto.assert$((byte)42);
	dto.final$((byte)7);
	dto.abstract$((byte)-81);
	dto.false$((byte)0);
	dto.falsE((byte)1);
	final ExpandableArrayBuffer input = new ExpandableArrayBuffer();
	final KeywordsEncoder encoder = new KeywordsEncoder();
	encoder.wrap(input, 0);
	KeywordsDto.encodeWith(encoder, dto);
	final byte[] originalBytes = new byte[encoder.encodedLength()];
	input.getBytes(0, originalBytes);
	final KeywordsDto otherDto =
	KeywordsDto.decodeFrom(input, 0, KeywordsEncoder.SCHEMA_VERSION, KeywordsEncoder.BLOCK_LENGTH);
	KeywordsDto.encodeWith(encoder, otherDto);
	final byte[] otherBytes = new byte[encoder.encodedLength()];
	input.getBytes(0, otherBytes);
	assertArrayEquals(originalBytes, otherBytes);
	}

And dto_test.KeywordsDto#encodeWith(dto_test.KeywordsEncoder, dto_test.KeywordsDto) looks like this:

    public static void encodeWith(KeywordsEncoder encoder, KeywordsDto dto)
    {
        encoder.abstract$(dto.abstract$());
        encoder.assert$(dto.assert$());
        encoder.boolean$(dto.boolean$());
        encoder.break$(dto.break$());
        encoder.byte$(dto.byte$());
        encoder.case$(dto.case$());
        encoder.catch$(dto.catch$());
        ...
        encoder.false$(dto.false$());
        encoder._$(dto._$());
        encoder.falsE(dto.falsE());
    }

The schema is dto-test-schema.xml.

[shenzlx]

Add the following type and message definitions into your dto-test-schema.xml file:

<type name="CharArray9" primitiveType="char" length="9"  />

 <sbe:message id="4" name="AnotherTest" >
        <field id="1" name="NotKeywords" type="CharArray9" />
        <field id="2" name="Abstract" type="CharArray9"  />
        <field id="3" name="Final" type="CharArray9"  />
 </sbe:message>

Then, the generated AnotherTestDto class has the following code:

    public static void encodeWith(AnotherTestEncoder encoder, AnotherTestDto dto)
    {
        encoder.notKeywords(dto.notKeywords());
        encoder.abstract(dto.abstractSBE());
        encoder.final(dto.finalSBE());
    }

[vyazelenko]

@shenzlx This is now fixed with fbd3799.