[C#] For span based properties, is there a reason we return a new empty array when its not in the current version, rather than Array.Empty?

[dqwork]

See this line of code

https://github.com/aeron-io/simple-binary-encoding/blob/master/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java#L1144

is there a reason this doesn't generate returning Array.Empty<{type}>() rather than creating a new Array everytime?

[pveentjer]

I think you made a good point. I'm not a C# developer, so I'm no expert. But from what I understand the compiler will not optimize a [0] into a Array.Empty.

So I think this should be improved.

[pveentjer]

Perhaps that the compiler is smart enough to determine through escape analysis that the object doesn't need to be allocated on the heap, and instead can be allocated on the stack. Unfortunately I'm not that familiar with C# compiler optimizations.

[vyazelenko]

Fixed with #1080.