feat: Enhance extractor pack workflow with compile and bundle jobs #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the extractor pack workflow by separating compilation and bundling into distinct jobs and introducing multi-platform support. The changes improve the CI/CD pipeline structure while also refactoring the codebase to use consolidated import files.
- Separates extractor compilation and bundling into distinct workflow jobs with multi-platform support
- Introduces dry-run functionality and improved error handling in publishing scripts
- Consolidates provider and security imports into centralized modules
- Removes Bicep language support from the extractor configuration
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Restructures workflow with separate compile and bundle jobs, adds multi-platform matrix build |
| scripts/publish-extractor-pack.sh | Adds dry-run support, CodeQL binary detection, and dependency management |
| scripts/create-extractor-pack.sh | Removes commented code and improves CodeQL binary detection |
| ql/lib/hcl.qll | Consolidates imports to use new centralized Providers and Security modules |
| ql/lib/codeql/hcl/Providers.qll | New file consolidating all provider imports |
| ql/lib/codeql/hcl/Security.qll | New file consolidating security-related imports |
| codeql-extractor.yml | Removes Bicep language support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # create extractor pack | ||
| ./scripts/create-extractor-pack.sh | ||
| # Check extracrtor-pack |
There was a problem hiding this comment.
Typo in comment: 'extracrtor-pack' should be 'extractor-pack'.
Suggested change
| # Check extracrtor-pack | |
| # Check extractor-pack |
Copilot uses AI. Check for mistakes.
| with: | ||
| submodules: true | ||
|
|
||
| - name: "Downloadd all artifacts" |
There was a problem hiding this comment.
Typo in step name: 'Downloadd' should be 'Download'.
Suggested change
| - name: "Downloadd all artifacts" | |
| - name: "Download all artifacts" |
Copilot uses AI. Check for mistakes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| submodules: true | ||
|
|
||
| - name: "Set up Rust" | ||
| uses: dtolnay/rust-toolchain@nightly |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.