Skip to content

Conversation

@ycarooliveira
Copy link
Contributor

@ycarooliveira ycarooliveira commented Aug 27, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • #Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing

@antoine92190
Copy link
Collaborator

Thanks a lot for this feature!
I will test it locally, but in the meantime could you revert the code styling changes above?
I'm using prettier and eslint to enforce code styling convention.

@ycarooliveira
Copy link
Contributor Author

Nah I should have send this PR a long time ago...
I'll try to revert the styling, my vscode is acting up, it's ignoring the eslint file for some reason and using my default config settings

@antoine92190
Copy link
Collaborator

@ycarooliveira Why did you close this?

@ycarooliveira ycarooliveira reopened this Sep 10, 2021
@ycarooliveira
Copy link
Contributor Author

@ycarooliveira Why did you close this?

err Idk LMAO

@antoine92190 antoine92190 merged commit b9c627e into advanced-chat:master Sep 11, 2021
@antoine92190
Copy link
Collaborator

Thanks again! Love the UX to select templates with keyboard, will add that for user tags and emojis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants