Skip to content

Conversation

@mbuk
Copy link
Contributor

@mbuk mbuk commented Jul 17, 2021

Fix for #153 adds a vanilla JS debounce with associated changes to improve performance when there are a lot of messages loaded

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

…prove performance when you have a large number (> 250 messages loaded)
@antoine92190
Copy link
Collaborator

Look great, thanks a lot!

@antoine92190 antoine92190 merged commit c5666f7 into advanced-chat:master Jul 17, 2021
@mbuk
Copy link
Contributor Author

mbuk commented Jul 17, 2021

Not at all buddy glad to be able to give something back. Thanks of all the work on the package - it's awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants